Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape paths correctly + Run specs against JRuby on Appveyor. #131

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Escape paths correctly + Run specs against JRuby on Appveyor. #131

merged 3 commits into from
Jun 11, 2019

Conversation

kapoorlakshya
Copy link
Collaborator

@kapoorlakshya kapoorlakshya commented Jun 9, 2019 •
edited
Loading

This PR addresses three things:

  1. Fixes Chrome binary cannot be located on Windows (JRuby) #130 and [3.7.0] Crashes with Jruby Windows #41 (JRuby related) on Windows.
  2. Fixes path separator issues on Windows:
Failure/Error: expect(iedriver.driver_path).to eq("#{File.join(ENV['HOME'])}/.webdrivers/IEDriverServer.exe")

       expected: "C:\\Users\\Skittles/.webdrivers/IEDriverServer.exe"
            got: "C:/Users/Skittles/.webdrivers/IEDriverServer.exe"

       (compared using ==)
     # ./spec/webdrivers/i_edriver_spec.rb:189:in `block (3 levels) in <top (required)>'
  1. Now runs specs against JRuby on Appveyor to avoid Chrome binary cannot be located on Windows (JRuby) #130 in the future.

@kapoorlakshya kapoorlakshya mentioned this pull request Jun 11, 2019
Merged
@kapoorlakshya kapoorlakshya merged commit 6fd9b44 into titusfortner:master Jun 11, 2019
@kapoorlakshya kapoorlakshya deleted the 130_jruby branch June 11, 2019 15:35
twalpole added a commit that referenced this pull request Jun 11, 2019
@twalpole
Implement PR #131 for Edge
db5f04c
twalpole added a commit that referenced this pull request Jun 12, 2019
@twalpole
Implement PR #131 for Edge
fb84892
@kapoorlakshya kapoorlakshya mentioned this pull request Jun 18, 2019
Closed
twalpole added a commit that referenced this pull request Jun 22, 2019
@twalpole
Implement PR #131 for Edge
8fee61b
twalpole added a commit that referenced this pull request Jun 25, 2019
@twalpole
Implement PR #131 for Edge
84fb031
twalpole added a commit that referenced this pull request Jun 25, 2019
@twalpole
Add Chromium based Edge support to webdrivers (#128)
b34aec2 
* Initial addition of Edge Chrome to webdrivers

* Allow finding Microsoft Edge Dev on OSX

* Update gem requirement due to edge_chrome_rb branch being merged

* Add Edge finding on Windows

* Implement PR #131 for Edge

* Run edge tests on appveyor

* Don't try and get version when binary isn't found

* Change preference order of edge binary

* Update to match recent Chrome support changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titusfortner titusfortner titusfortner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chrome binary cannot be located on Windows (JRuby)
2 participants
@kapoorlakshya @titusfortner