Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot provide custom name for app #292

Closed
lawrencejones opened this issue Dec 4, 2014 · 2 comments
Closed

Cannot provide custom name for app #292

lawrencejones opened this issue Dec 4, 2014 · 2 comments

Comments

@lawrencejones
Copy link
Contributor

Line 404 is where the name of your application is currently guessed. I don't think this is the best way of doing things, or at least we should have an option to set the name of the application much like the description.

If we don't have this, then many apps will end up printing usage: cli.js or whatever the file being run may be, which I think looks pretty rubbish.

Simply adding a method to set the programs name would solve this problem. Making a PR now.

lawrencejones pushed a commit to lawrencejones/commander.js that referenced this issue Dec 4, 2014
@lawrencejones
Copy link
Contributor Author

Turns out there was already a getter for the app name, that took a parameter name but didn't do anything with it. Not sure what happened there?

PR should allow custom setting of name in the same way as other standard parameters.

SomeKittens added a commit that referenced this issue Dec 5, 2014
@zhiyelee
Copy link
Collaborator

zhiyelee commented Dec 5, 2014

Closed. We can discuss in #293

@zhiyelee zhiyelee closed this as completed Dec 5, 2014
zhiyelee added a commit that referenced this issue Dec 7, 2014
zhiyelee added a commit that referenced this issue Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants