Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make app name settable #292 #293

Merged
merged 1 commit into from
Dec 5, 2014
Merged

Make app name settable #292 #293

merged 1 commit into from
Dec 5, 2014

Conversation

lawrencejones
Copy link
Contributor

Turns out this was ever easier than I thought it would be. The prototype.name function already took a name parameter, but for some reason didn't allow setting?

With this alteration you can now set the name of your command very much like you would the description.

program = require('commander')

program
  .name('nice-cli-name')
  .description('your standard app')

@SomeKittens
Copy link
Collaborator

LGTM. Thanks!

SomeKittens added a commit that referenced this pull request Dec 5, 2014
@SomeKittens
Merge pull request #293 from LawrenceJones/custom-name
1a065da 
Make app name settable #292
@SomeKittens SomeKittens merged commit 1a065da into tj:master Dec 5, 2014
@zhiyelee
Copy link
Collaborator

zhiyelee commented Dec 5, 2014

Wait, there is a bug. See #266

This was referenced Dec 5, 2014
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lawrencejones @SomeKittens @zhiyelee