Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds travis CI support #64

Merged
merged 9 commits into from
Jul 16, 2017
Merged

Adds travis CI support #64

merged 9 commits into from
Jul 16, 2017

Conversation

deiga
Copy link
Collaborator

@deiga deiga commented Jul 11, 2017

No description provided.

@deiga
Copy link
Collaborator Author

deiga commented Jul 12, 2017

@tj Can you enable travis CI for me or can you give me enough permissions, to do it myself? :)

@deiga
Copy link
Collaborator Author

deiga commented Jul 13, 2017

@tj Sorry to be a bother, but could you respond to this? :)

@tj
Copy link
Owner

tj commented Jul 16, 2017

should be good to go now

@deiga deiga force-pushed the add-travis-support branch from db83028 to da8c463 Compare July 16, 2017 18:47
@deiga deiga merged commit 4b022b1 into master Jul 16, 2017
@deiga deiga deleted the add-travis-support branch July 16, 2017 20:10
@lbeschastny
Copy link
Contributor

Shouldn't eslint-plugin-node be a devDependency?

Right not this PR cause the following warning after installing the latest node-growl from npm:

npm WARN eslint-plugin-node@5.1.1 requires a peer of eslint@>=3.1.0 but none is installed. You must install peer dependencies yourself.

@lbeschastny lbeschastny mentioned this pull request Sep 15, 2017
Merged
@deiga deiga restored the add-travis-support branch April 4, 2018 15:44
@deiga deiga deleted the add-travis-support branch April 4, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deiga @tj @lbeschastny