Move eslint-plugin-node to devDependencies section in package.json

[lbeschastny]

eslint-plugin-node is a development dependency and should be in a devDependency section.

Right now installing node-growl from npm causes the following warning:

npm WARN eslint-plugin-node@5.1.1 requires a peer of eslint@>=3.1.0 but none is installed. You must install peer dependencies yourself.

Related to #64.

[deiga]

Thank you!

[kumarrishav]

After this change, build is breaking for same reason.

├─┬ mocha-jenkins-reporter@0.1.9 
03:31:22 │ ├── diff@1.0.7 
03:31:22 │ ├─┬ mkdirp@0.5.0 
03:31:22 │ │ └── minimist@0.0.8 
03:31:22 │ └─┬ mocha@4.0.0 
03:31:22 │   ├── browser-stdout@1.3.0 
03:31:22 │   ├── debug@3.1.0 
03:31:22 │   ├── diff@3.3.1 
03:31:22 │   ├─┬ growl@1.10.2 
03:31:22 │   │ ├── UNMET PEER DEPENDENCY eslint@>=3.1.0
03:31:22 │   │ └─┬ eslint-plugin-node@5.2.0 
03:31:22 │   │   ├── ignore@3.3.5 
03:31:22 │   │   └── semver@5.3.0 
03:31:22 │   ├── he@1.1.1 
03:31:22 │   ├── mkdirp@0.5.1 
03:31:22 │   └─┬ supports-color@4.4.0 
03:31:22 │     └── has-flag@2.0.0 

npm WARN eslint-plugin-node@5.2.0 requires a peer of eslint@>=3.1.0 but none was installed.

[lbeschastny]

@kumarrishav try to uninstall growl and then install the latest version, instead of updating an old version.

npm may've left eslint-plugin-node in growl's node_modules folder despite it being removed from package.json.

[kumarrishav]

I am still getting the same. even after doing rm -rf node_modules

[deiga]

Well there hasn't been a release yet, as this only a minor change. And this issue shouldn't break anything

[kumarrishav]

hmm. ok anyway. i have added eslint as devDependency of my app

[kumarrishav]

got the actual issue. So, there was a version bump in mocha (to 4.0.0) which cause this because of:
juhovh/mocha-jenkins-reporter#70

[SimenB]

Can this get a release? Mocha pulls this in, so everybody using mocha and not eslint will get a warning from npm/yarn at install

[deiga]

@SimenB done