Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update demo for accessibility testing #12

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

scottaohara
Copy link
Contributor

Related to @aardrian's comments in issue #7, the PR:

  • Adds html lang=“en” to the demo file to help with AT testing.
  • Changes the incorrect aria-role attribute to role

per @domenic's comment of:

In general the idea is that this should be like a built-in HTML control in all ways possible

this PR does not include any updates for exposing the switch as disabled with aria-disabled. That can be done in a separate PR if needed.

Thank you

Adds `html lang=“en”` to the demo file to help with AT testing.

Changes the incorrect `aria-role` attribute to `role`
Copy link
Owner

@tkent-google tkent-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@tkent-google tkent-google merged commit 4e3a1b6 into tkent-google:master Jun 6, 2019
@scottaohara scottaohara deleted the demo-updates branch June 6, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants