Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo readme updates #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Demo readme updates #13

wants to merge 2 commits into from

Conversation

scottaohara
Copy link
Contributor

This PR provides:

Thank you

@scottaohara
cleanup readme
a7fae75 
fixes instances of tripple backticks to single.
fixes typo for “Acknowledgments”
@scottaohara
do not expose track text to a11y api
42cf1a8 
the text on track is meant as a visual text representation of state.

However this text should *not* be exposed to the accessibility api / be included in the accessible name of the control, as it would cause redundant announcements to the change in state that is provided by the control itself (e.g. `aria-checked=“true/false”`

the addition of `aria-hidden=“true”` to the track ensures this text will not be exposed.
@tkent-google
Copy link
Owner

This repository has no license term and no contribution agreement now. So I need to take care of the copyright of your changes.

  • I'll drop your changes of switch.mjs when I move it to Chromium repository, which doesn't allow contribution without agreement signing.
  • I don't want to accept README.md changes because I'm going to copy it to WICG repository. I would have to ask you for copy permission if I accepted the change.

I should have mentioned this in the previous PR #12

@scottaohara
Copy link
Contributor Author

Understood @tkent-google. The readme stuff is just typos anyway, so no worries there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottaohara @tkent-google