Refactor fixup #51
Merged
Refactor fixup #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able amount of time. * Renamed fixup kwarg to validate_frames in _chunkmap.read_new_chunkmap. * Set validate_frames to default to False. * Renamed bad/fixed/safe to bad/fixed/good in read_chunkmap. * Add validate_frames and search_window kwargs to ND2File.__init__ to pass through to _util.get_reader -> _sdk/latest.ND2Reader.__init__ -> _chunkmap.read_new_chunkmap.
|
Thanks! I pushed some slight fixes directly to your branch (where the keyword "safe" was still being used) |
can you tell me how you set up the environment? (I think you're one of the first to try)... we can dig into this in another issue though |
|
all green! thanks a lot @shenker! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
@tlambert03 I'm running into horrible library path issues (probably related to #24) so I can't test this myself currently... I'm trying to fix things, will probably open another issue later today.