Fix frame offsets when validate_frames != True, add validate_frames param to imread
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlambert03
changed the title
validate_frames param to imread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the remaining issues that @KaSaBe had after #51, mentioned in #50 (comment)
This was actually a latent bug that wasn't being tested. (@KaSaBe, your files are just fine and didn't need the
validate_framesargument at all, there was just an offset error being hidden otherwise).Test added, so shouldn't happen again
edit: The vast majority of this PR is actually mostly just docs, and adding the
validate_framesargument tond2.imread, the real fix is this line: https://github.com/tlambert03/nd2/pull/54/files#diff-0838554df4a5ec6bdc4f03e3a3d48befd1da843bc8a3edc88e361ea90671ddaeR168