Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added go client to the list. #30

Merged
merged 1 commit into from
Dec 30, 2018

Conversation

isacikgoz
Copy link
Contributor

Hi,

Added go client to the clients list. It is the most popular go client.

Thanks in advance.

@agnivade
Copy link
Member

@waldyrious - I think we discussed this before. There are currently 3 places which lists clients - this one, the tldr wiki, and the tldr home page. Are we going to update all 3 of them every time we add a new client ?

IMO - we should freeze this list and just add more clients in the home page and wiki.

@isacikgoz
Copy link
Contributor Author

Thank you for the quick attention. I would be very happy if you freeze after this PR.

If I supposed to add my two cents, This list should contain most active/popular clients IMHO.

p.s. I would like to thank you for all this work.

@sbrl
Copy link
Member

sbrl commented Dec 25, 2018

How would you suggest measuring client popularity?

@isacikgoz
Copy link
Contributor Author

@sbrl github stars may give a clue, or gitlab etc

@waldyrious
Copy link
Member

waldyrious commented Dec 27, 2018

@waldyrious - I think we discussed this before. There are currently 3 places which lists clients - this one, the tldr wiki, and the tldr home page. Are we going to update all 3 of them every time we add a new client ?

Funny coincidence, just the other day I started updating the list of clients in the wiki. It now contains all the clients that are listed in the website, so my next step was going to be to submit a PR removing the list from the website and pointing to the wiki. Later I'd propose moving the contents of the wiki to the main repo's README.

So @isacikgoz, if you could, please add this to the wiki page instead, otherwise we'd be merging this change only to revert it in a few days. But if you prefer having this merged anyway, that's fine by me.

As for the popularity measures, that sounds like a good idea. I'll ping you when I open the issue/PR for consolidating the list of clients, where it will be more on-topic to discuss this.

@isacikgoz
Copy link
Contributor Author

hey @waldyrious , It depends on how quick you move the page :) if it will take some time. I would be happy if you accept the PR!

@agnivade
Copy link
Member

@isacikgoz - If your client is on both the wiki and the tldr front pages, then I don't think you have anything to lose. 😄 People generally tend to visit the tldr front page.

@waldyrious
Copy link
Member

waldyrious commented Dec 30, 2018

I guess there's no harm in accepting the PR even if the content is removed soon. The time/effort to propose the PR has already been spent, so I say let's make it worth its while :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants