Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the lists of clients on the wiki and the README #5512

Closed
waldyrious opened this issue Mar 26, 2021 · 22 comments
Closed

Merge the lists of clients on the wiki and the README #5512

waldyrious opened this issue Mar 26, 2021 · 22 comments
Assignees
Labels
clients Issues pertaining to a particular client or the clients as whole. documentation Issues/PRs modifying the documentation.

Comments

@waldyrious
Copy link
Member

waldyrious commented Mar 26, 2021

Note: This has been discussed in various places (e.g. here and here), but apparently we never wrote it down into an actual issue. (The closest we got to that was a mini-project in our wiki page for Google Season of Docs, which is where most of the text below comes from.)

There are currently two lists of clients, each maintained independently: one in the README, and one in a wiki page. (There actually used to be a third one 😱 in the website, but it was merged a while ago by @20manas in tldr-pages/tldr-pages.github.io#53.)

We want the client lists to live at a single place, so that the lists won't get outdated or out of sync with each other.

The goal is to merge the two lists without losing any relevant information, and keeping the final result readable and easy to consume.

The final list can live at either of the two existing places, or at a new location (e.g. a new CLIENTS.md file). The existing locations should either embed or link to the unified list.

Once the lists are merged, we can also discuss the possibility of splitting the list into several sections based on relevant criteria (beyond the current division, which is by platform / language). For example:

For convenience, here are again the links to the existing lists of clients:

@bl-ue bl-ue added the documentation Issues/PRs modifying the documentation. label Mar 26, 2021
@MasterOdin
Copy link
Collaborator

My vote would be on having it just be in the wiki, which allows people to self add clients. For most projects I've seen that go this route, I'm not sure I've really seen any instance of spam or whatever on the wiki even though its publicly editable.

@bl-ue
Copy link
Contributor

bl-ue commented Mar 26, 2021

The only part-issue I see with that approach is that maintainers wouldn't know when there's a new client unless they're watching the repository (because GH adds an entry to your feed about users modifiying the wiki of a repo if you watching it), and they take the time to check what the user changed.

@sbrl
Copy link
Member

sbrl commented Mar 26, 2021

Yeah, we really need to tidy this up.

The wiki would be a sensible place to put it, but we would of course need a prominent link to it in the README

@waldyrious waldyrious added the clients Issues pertaining to a particular client or the clients as whole. label Mar 26, 2021
@kitarp29
Copy link
Contributor

@waldyrious Could you assign this to me??

@sbrl
Copy link
Member

sbrl commented Oct 20, 2021

@kitarp29 if you could submit a pull request, that would be great @kitarp29!

@kitarp29
Copy link
Contributor

@marchersimon I updated the wiki page.
How Do I create a PR?
I mean where is the source file for that wiki page?

@marchersimon
Copy link
Collaborator

Only members can edit the wiki pages, there's no way to open a PR unfortunately. But you could open an issue, where you paste the content.

@kitarp29
Copy link
Contributor

So my contributions can't get merged? @marchersimon

@marchersimon
Copy link
Collaborator

I don't think so.
@sbrl @navarroaxel do you know if there would be a way?

@navarroaxel
Copy link
Collaborator

navarroaxel commented Oct 26, 2021

Based on this docs https://docs.github.com/en/communities/documenting-your-project-with-wikis/changing-access-permissions-for-wikis anyone is allowed to edit the wiki, via web UI or Git repo.

@kitarp29
Copy link
Contributor

I edited that already @navarroaxel

@sbrl
Copy link
Member

sbrl commented Oct 28, 2021

That's weird, I thought for sure anyone could edit the wiki.

@sbrl
Copy link
Member

sbrl commented Oct 28, 2021

You should be able to clone the wiki as a git repository, so if you can attach a patch file to this repo I can merge it into the wiki that way.

@MasterOdin
Copy link
Collaborator

@sbrl @marchersimon The wiki page was updated by @kitarp29 already: https://github.com/tldr-pages/tldr/wiki/tldr-pages-clients/_history. I think they were looking to get a "PR merge" though for this (for hacktoberfest?), which unfortunately cannot happen as wikis don't have PRs.

The next step imo would be to probably remove the list from the README and just have it link to the wiki, which can be a PR made by @kitarp29.

@kitarp29
Copy link
Contributor

@MasterOdin leave I don't want to make a PR for the sake of it. I helped very little to this repo, as I am just starting with OpenSource. You will be seeing more messages by me in this repo 🤓😅.
If the issue is resolved, please go ahead and close it.
Thanks 😊

@marchersimon
Copy link
Collaborator

Documentation is actually very important, don't underestimate your work. Thanks for your help!

@MasterOdin
Copy link
Collaborator

@marchersimon reopening this issue as the primary objective of it:

We want the client lists to live at a single place, so that the lists won't get outdated or out of sync with each other.

is still not done. We still have two lists (README.md and Wiki), and should consolidate behind one.

We should open a PR to simplify the README to just point at the wiki, and maybe mention how to install just the official clients.

@MasterOdin MasterOdin reopened this Nov 1, 2021
@kitarp29
Copy link
Contributor

kitarp29 commented Nov 2, 2021

@MasterOdin Can I work on it??

@marchersimon
Copy link
Collaborator

Sure, if you like to

kitarp29 added a commit to kitarp29/tldr that referenced this issue Nov 6, 2021
tldr-pages#5512 
As suggested by @MasterOdin, I removed the list of clients from the REAME.md and redirected them to the wiki page.
This is a small PR, won't need much review I guess.
IT AIN'T MUCH BUT IT'S HONEST WORK
@kitarp29
Copy link
Contributor

kitarp29 commented Nov 6, 2021

@MasterOdin #7381
did the changes and updated README.md

@sbrl
Copy link
Member

sbrl commented Nov 25, 2021

Awesome, @kitarp29! Does this mean we can close this issue now?

@kitarp29
Copy link
Contributor

Yes this got merged.
Go ahead and close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients Issues pertaining to a particular client or the clients as whole. documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

No branches or pull requests

7 participants