Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace list of clients with a link to the wiki #53

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Replace list of clients with a link to the wiki #53

merged 1 commit into from
Jan 1, 2021

Conversation

20manas
Copy link
Contributor

@20manas 20manas commented Dec 31, 2020 •
edited by waldyrious
Loading

Replace the list of clients with a link to the wiki which contains the updated list of clients.

The discussion is going on in #52.

waldyrious
waldyrious requested changes Dec 31, 2020
View reviewed changes
Copy link
Member

@waldyrious waldyrious left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing us to finally address this (and actually taking the lead in doing it)!

I've left a few minor suggestions, after which this should be ready to go!

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@20manas 20manas requested a review from waldyrious December 31, 2020 18:32
waldyrious
waldyrious approved these changes Jan 1, 2021
View reviewed changes
Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @20manas! Since these changes have been discussed and agreed in #52, I'll go ahead and merge the PR.

@waldyrious waldyrious changed the title Replace the list of clients with a link to the wiki which contains th… Replace list of clients with a link to the wiki Jan 1, 2021
@waldyrious waldyrious merged commit 5458901 into tldr-pages:master Jan 1, 2021
@waldyrious waldyrious mentioned this pull request Jan 1, 2021
Closed
@waldyrious waldyrious mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldyrious waldyrious waldyrious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@20manas @waldyrious