Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kate: add page #5834

Merged
merged 5 commits into from
Apr 27, 2021
Merged

kate: add page #5834

merged 5 commits into from
Apr 27, 2021

Conversation

navarroaxel
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Apr 25, 2021
marchersimon
marchersimon reviewed Apr 25, 2021
View reviewed changes
pages/common/kate.md Outdated Show resolved Hide resolved
marchersimon
marchersimon reviewed Apr 26, 2021
View reviewed changes
pages/common/kate.md Outdated Show resolved Hide resolved
bl-ue
bl-ue reviewed Apr 26, 2021
View reviewed changes
pages/common/kate.md Outdated Show resolved Hide resolved
navarroaxel and others added 2 commits April 26, 2021 09:11
@navarroaxel @bl-ue
Update pages/common/kate.md
12c6746 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@navarroaxel
Explain line and column variables
b67f836
@navarroaxel navarroaxel requested a review from bl-ue April 26, 2021 12:13
bl-ue
bl-ue reviewed Apr 26, 2021
View reviewed changes
pages/common/kate.md Show resolved Hide resolved
pages/common/kate.md Outdated Show resolved Hide resolved
@navarroaxel navarroaxel requested a review from bl-ue April 26, 2021 15:07
@navarroaxel @bl-ue
Apply suggestions from code review
6cf6cf9 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
bl-ue
bl-ue reviewed Apr 26, 2021
View reviewed changes
pages/common/kate.md

- Open a remote document in Kate:

`kate {{https://example.com}}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`kate {{https://example.com}}`
`kate {{https://example.com/path/to/file}}`

@Waples Waples merged commit 051ec5e into master Apr 27, 2021
@marchersimon
Copy link
Collaborator

@Waples, there was an open suggestion by @bl-ue 🤔

@navarroaxel navarroaxel deleted the pages/kate branch April 27, 2021 16:28
@navarroaxel navarroaxel mentioned this pull request Apr 27, 2021
Merged
6 tasks
@navarroaxel
Copy link
Collaborator Author

navarroaxel commented Apr 27, 2021 •
edited
Loading

@Waples, there was an open suggestion by @bl-ue thinking

@marchersimon Open PR to apply the suggestion #5842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue left review comments

@marchersimon marchersimon marchersimon approved these changes

@Waples Waples Waples approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navarroaxel @marchersimon @Waples @bl-ue