Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kate: improve remote document example #5842

Merged
merged 1 commit into from
Apr 27, 2021
Merged

kate: improve remote document example #5842

merged 1 commit into from
Apr 27, 2021

Conversation

navarroaxel
Copy link
Collaborator

@navarroaxel navarroaxel commented Apr 27, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Resolve open discussion in #5834

@navarroaxel navarroaxel added the page edit Changes to an existing page(s). label Apr 27, 2021
@navarroaxel navarroaxel mentioned this pull request Apr 27, 2021
6 tasks
@Waples Waples merged commit d08f5eb into master Apr 27, 2021
@navarroaxel navarroaxel deleted the pages/kate branch April 27, 2021 16:43
@navarroaxel
Copy link
Collaborator Author

@Waples don't be an eager merger. if I request the review of @bl-ue is for check if has more comments or suggestion over this page.

@bl-ue
Copy link
Contributor

bl-ue commented Apr 27, 2021

@Waples usually it's good to give a PR some time before merging, if it's approved enough. I usually respond to notifications quickly, so I would have seen this relatively soon after I was requested.

As for approval, @navarroaxel here you go: ✅

@bl-ue bl-ue removed their request for review April 27, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants