Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: remove list of clients #7381

Merged
merged 3 commits into from
Nov 8, 2021
Merged

README: remove list of clients #7381

merged 3 commits into from
Nov 8, 2021

Conversation

kitarp29
Copy link
Contributor

@kitarp29 kitarp29 commented Nov 6, 2021

#5512
As suggested by @MasterOdin, I removed the list of clients from the REAME.md and redirected them to the wiki page.
This is a small PR, won't need much review I guess.
IT AIN'T MUCH BUT IT'S HONEST WORK

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):

tldr-pages#5512 
As suggested by @MasterOdin, I removed the list of clients from the REAME.md and redirected them to the wiki page.
This is a small PR, won't need much review I guess.
IT AIN'T MUCH BUT IT'S HONEST WORK
@CLAassistant

This comment has been minimized.

@marchersimon marchersimon added the documentation Issues/PRs modifying the documentation. label Nov 6, 2021
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Updated with suggestions

Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@kitarp29
Copy link
Contributor Author

kitarp29 commented Nov 6, 2021

Done the changes.

@marchersimon
Copy link
Collaborator

You haven't addressed my first comment yet. The link to the list can very easily be overlooked at the moment.

empasis on various other clients
@kitarp29
Copy link
Contributor Author

kitarp29 commented Nov 7, 2021

Sorry my bad.
I made "various other clients" as bold

Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kitarp29

@marchersimon marchersimon added the review needed Prioritized PRs marked for reviews from maintainers. label Nov 7, 2021
@marchersimon marchersimon changed the title Updated README.md README: remove list of clients Nov 7, 2021
@pixelcmtd pixelcmtd merged commit 8d3b6b4 into tldr-pages:main Nov 8, 2021
@navarroaxel navarroaxel removed the review needed Prioritized PRs marked for reviews from maintainers. label Nov 9, 2021
@kitarp29
Copy link
Contributor Author

kitarp29 commented Nov 9, 2021

dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants