Reduce argument allocations for checkArgument to reduce gc pressure. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependency updates
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
DNS Resolver - catch for all exceptions
* build - Fix NOTICE * build - publish to GH Packages * build - GH action to publish to GH packages * build - Update check notice * Update .github/workflows/publish.yml Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * build - Update groupId --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
allocate more memory for ref tests task Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* allocate more memory for ref tests task --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Karim TAAM <karim.t2am@gmail.com>
|
You will need to run spotless. |
|
@atoulme improvement for memory allocation - are you accepting PRs into this project? |
atoulme
approved these changes
Oct 14, 2024
|
looks like the GPG signing key has expired @atoulme |
|
I'll take a look. |
Existing gpg key has been expired and build fails. New key has been generated and updated. New key expires on 2026-10-14 Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
|
@atoulme would it be possible to get write access for me and a few others on this repo? Would like to get this change merged and be able to do releases when required. |
|
@atoulme this PR includes groupid change in build.gradle which is going to cause issues when publishing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The checkArgument( boolean, String, ... ) causes a large number of Integer and int[] to be created temporarily on the heap which causes gc pressure. This PR adds overloads which reduces object allocations to 0 for these method calls.
Fixed Issue(s)