fix vertx registering handlers #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
pushed a commit
that referenced
this pull request
Oct 16, 2024
…104) * catch any exception Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * GH Publish (#4) * build - Fix NOTICE * build - publish to GH Packages * build - GH action to publish to GH packages * build - Update check notice * Update .github/workflows/publish.yml Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * build - Update groupId --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> * allocate memory explicitly for ref tests task (#6) allocate more memory for ref tests task Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * Memory ref tests (#7) * allocate more memory for ref tests task --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * change log level (#1) Co-authored-by: Karim TAAM <karim.t2am@gmail.com> * Reduce argument allocations for checkArgument to reduce gc pressure. * spotless changes. * Update GPG key (#11) Existing gpg key has been expired and build fails. New key has been generated and updated. New key expires on 2026-10-14 Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Usman Saleem <usman@usmans.info> Co-authored-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Chaminda Divitotawela <cdivitotawela@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixes a regression seen with Vert.x upgrade, where the registration of handlers is no longer on by default.