refactor(edgeless): element tree manager #8239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1e7573e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
L-Sun
changed the title
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
818cecd
to
a21a0ac
Compare
doouding
reviewed
Sep 12, 2024
doouding
pushed a commit
that referenced
this pull request
Sep 12, 2024
Closes: [BS-1398](https://linear.app/affine-design/issue/BS-1398/[bug]-拖出-frame-后-mindmap-依然跟随-frame), [BS-1400](https://linear.app/affine-design/issue/BS-1400/mindmap无法移出frame) This PR fix mindmap is moved with frame moving when the mindmap has been drag out of frame. ### What changes - add workround to avoid multiple container in `FrameManager` for nodes of mindmap. - The fix can be refactored after #8239 - add frame and mindmap e2e tests
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
a21a0ac
to
3db021b
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
3db021b
to
8824b32
Compare
size-limit report 📦
|
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
8824b32
to
87b543d
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
87b543d
to
2720313
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
2720313
to
baef0d2
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
baef0d2
to
ffddf7c
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
ffddf7c
to
a4d70cd
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
a4d70cd
to
6948bd8
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
6948bd8
to
4565077
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
4565077
to
7433fda
Compare
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
7433fda
to
80a2b6d
Compare
Merge activity
|
### TL;DR This PR introduces `TreeManager` to maintain the container-children relationship among `GfxModel`s. This change can make sure an element only has zero or one container. ### What changes: - A new `TreeManager` is introduced to maintain the container-children relationship. Its implementation references the relevant code previously used in group in `surface-model.ts`. - Removed code related to the container-children relationship watcher of group. - The `ContainerElement` interface and related code have been moved from `element-model.ts` to a new file, `container-element.ts`. - Simplified the implementation of the `ContainerElement` interface in `GroupLikeModel` and `FrameModel`. - Some type annotation changes: from `BlockSuite.EdgelessModel` to `GfxModel`. ### About test: The existing tests already cover the changes mentioned above, including the relationship changes after operations on the child elements of frames and groups.
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
80a2b6d
to
1e7573e
Compare
L-Sun
added a commit
that referenced
this pull request
Oct 14, 2024
This PR removes redundant code related to the container-child element relationship, which is now maintained by the new `TreeManager` after #8239 .
L-Sun
added a commit
that referenced
this pull request
Oct 14, 2024
This PR refactor group test utils with container interface after PR #8239
donteatfriedrice
added a commit
that referenced
this pull request
Oct 16, 2024
## Features: [feat: markdown adapter with latex](#8503) [feat: support notion block equation html import](#8504) [feat: support edgeless tidy up](#8516) [feat: support notion callout block to blocksuite quote block](#8523) [feat(playground): add import notion zip entry](#8527) ## Bugfix: [fix(blocks): auto focus latex block](#8505) [fix: enhance button layout with icon alignment](#8508) [fix(edgeless): ime will crash edgeless text width](#8506) [fix(edgeless): edgeless text is deleted when first block is empty](#8512) [fix: notion html quote block import](#8515) [fix: yjs warning](#8519) [fix(blocks): real nested list on html export](#8511) [fix(edgeless): cmd a will select element inner frame](#8517) [fix(edgeless): disable contenteditable when edgeless text not in editing state](#8525) [fix: import notion toggle list as toggle bulleted list](#8528) ## Refactor: [refactor(database): signals version datasource api](#8513) [refactor(edgeless): element tree manager](#8239) [refactor(blocks): simplify frame manager implementation](#8507) [refactor: update group test utils using container interface](#8518) [refactor: update frame test with container test uitls](#8520) [refactor(database): context-menu ui and ux](#8467) [refactor: move chat block to affine](#8420) ## Misc [perf: optimize snapshot job handling](#8428) [perf(edgeless): disable shape shadow blur](#8532) [chore: bump up all non-major dependencies](#8514) [chore: Lock file maintenance](#8510) ## Docs [docs: fix table structure warning](#8509) [docs: edgeless data structure desc](#8531) [docs: update link](#8533)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR introduces
TreeManagerto maintain the container-children relationship amongGfxModels. This change can make sure an element only has zero or one container.What changes:
TreeManageris introduced to maintain the container-children relationship. Its implementation references the relevant code previously used in group insurface-model.ts.ContainerElementinterface and related code have been moved fromelement-model.tsto a new file,container-element.ts.ContainerElementinterface inGroupLikeModelandFrameModel.BlockSuite.EdgelessModeltoGfxModel.About test:
The existing tests already cover the changes mentioned above, including the relationship changes after operations on the child elements of frames and groups.