Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edgeless): multi parent container of node of mindmap #8317

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Sep 12, 2024

Closes: BS-1398, BS-1400

This PR fix mindmap is moved with frame moving when the mindmap has been drag out of frame.

What changes

Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 51b9405

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 8:02am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 8:02am

Copy link

graphite-app bot commented Sep 12, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Sep 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 51b9405. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Sep 12, 2024

size-limit report 📦

Path Size
@blocksuite/affine-block-list 5.95 KB (0%)
@blocksuite/affine-block-paragraph 4.5 KB (0%)
@blocksuite/affine-block-surface 88.7 KB (0%)
@blocksuite/affine-components 1004.28 KB (0%)
@blocksuite/data-view 342.68 KB (-6.62% 🔽)
@blocksuite/affine-model 48.86 KB (0%)
@blocksuite/affine-shared 30.37 KB (0%)
@blocksuite/blocks 6.79 MB (+0.02% 🔺)
@blocksuite/block-std 149.55 KB (0%)
@blocksuite/global 28.4 KB (0%)
@blocksuite/inline 27.44 KB (0%)
@blocksuite/store 66.34 KB (0%)
@blocksuite/sync 96.01 KB (0%)
@blocksuite/presets 252.15 KB (0%)

@L-Sun L-Sun requested a review from doouding September 12, 2024 06:09
@L-Sun L-Sun marked this pull request as ready for review September 12, 2024 06:09
@L-Sun L-Sun requested a review from a team as a code owner September 12, 2024 06:09
Copy link

graphite-app bot commented Sep 12, 2024

Merge activity

Closes: [BS-1398](https://linear.app/affine-design/issue/BS-1398/[bug]-拖出-frame-后-mindmap-依然跟随-frame),  [BS-1400](https://linear.app/affine-design/issue/BS-1400/mindmap无法移出frame)

This PR fix mindmap is moved with frame moving when the mindmap has been drag out of frame.

### What changes
- add workround to avoid multiple container in `FrameManager` for nodes of mindmap.
  - The fix can be refactored after #8239
- add frame and mindmap e2e tests
@doouding doouding force-pushed the l-sun/fix/frame-mindmap-relation branch from 45a48b6 to 51b9405 Compare September 12, 2024 08:01
@graphite-app graphite-app bot merged commit 51b9405 into master Sep 12, 2024
36 checks passed
@graphite-app graphite-app bot deleted the l-sun/fix/frame-mindmap-relation branch September 12, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants