chore: test hyper on CI #4393
Merged
chore: test hyper on CI #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
approved these changes
Jan 11, 2022
taiki-e
commented
Jan 11, 2022
| echo 'tokio-stream = { path = "../tokio-stream" }' >>Cargo.toml | ||
| echo 'tokio-test = { path = "../tokio-test" }' >>Cargo.toml | ||
| git diff | ||
| cargo test --features full |
There was a problem hiding this comment.
Do we want to run benchmarks as well?
In #4390, I mentioned benchmarks, but I was actually able to reproduce both problems with only tests (I just missed that some of hyper's benchmarks don't work on macos).
There was a problem hiding this comment.
How do they work? Do they fail if something regresses, or?
There was a problem hiding this comment.
I'm going to merge. We can always add benchmarks in a new PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4390.
As said in #4392, this fails until cc8ad36 (#4377) is reverted (or until the regression introduced by that commit is fixed).UPD: cc8ad36 has been reverted in #4394