Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test hyper on CI #4393

Merged
merged 6 commits into from
Jan 11, 2022
Merged

chore: test hyper on CI #4393

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c34988e
chore: test hyper on CI
taiki-e Jan 11, 2022
595ba77
add windows and macos
taiki-e Jan 11, 2022
ea10d2c
use bash on windows
taiki-e Jan 11, 2022
a2278b5
use `git describe`
taiki-e Jan 11, 2022
22a9c1f
use stable
taiki-e Jan 11, 2022
ecef74c
Merge remote-tracking branch 'origin/master' into taiki-e/test-hyper
taiki-e Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ env:
nightly: nightly-2021-11-23
minrust: 1.46

defaults:
run:
shell: bash

jobs:
# Depends on all action sthat are required for a "successful" CI run.
tests-pass:
Expand All @@ -31,6 +35,7 @@ jobs:
- valgrind
- loom-compile
- check-readme
- test-hyper
steps:
- run: exit 0

Expand Down Expand Up @@ -355,3 +360,34 @@ jobs:
- name: Verify that Tokio version is up to date in README
working-directory: tokio
run: grep -q "$(sed '/^version = /!d' Cargo.toml | head -n1)" README.md

test-hyper:
name: Test hyper
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- windows-latest
- ubuntu-latest
- macos-latest
steps:
- uses: actions/checkout@v2
- name: Install Rust
run: rustup update stable
- uses: Swatinem/rust-cache@v1
- name: Test hyper
run: |
set -x
git clone https://github.com/hyperium/hyper.git
cd hyper
# checkout the latest release because HEAD maybe contains breakage.
tag=$(git describe --abbrev=0 --tags)
git checkout "${tag}"
echo '[workspace]' >>Cargo.toml
echo '[patch.crates-io]' >>Cargo.toml
echo 'tokio = { path = "../tokio" }' >>Cargo.toml
echo 'tokio-util = { path = "../tokio-util" }' >>Cargo.toml
echo 'tokio-stream = { path = "../tokio-stream" }' >>Cargo.toml
echo 'tokio-test = { path = "../tokio-test" }' >>Cargo.toml
git diff
cargo test --features full
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to run benchmarks as well?
In #4390, I mentioned benchmarks, but I was actually able to reproduce both problems with only tests (I just missed that some of hyper's benchmarks don't work on macos).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do they work? Do they fail if something regresses, or?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @seanmonstar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge. We can always add benchmarks in a new PR.