Skip to content

Commit

Permalink
Revert "tracing: fix name clash inside of tracing macros (#806)"
Browse files Browse the repository at this point in the history
This reverts commit e3b3a3a.

This change was accidentally semver-incompatible, as user code was able
to use the imported `debug` and `display` functions without adding an
import outside the macro. Although this was not documented, downstream
code relied on these names being available, so this resulted in a
breaking change in a point release.

Fixes #820
  • Loading branch information
hawkw committed Jul 21, 2020
1 parent f169043 commit 2feb61d
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions tracing/src/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1883,91 +1883,92 @@ macro_rules! valueset {
// };
(@ { $(,)* $($out:expr),* }, $next:expr, $($k:ident).+ = ?$val:expr, $($rest:tt)*) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$crate::field::debug(&$val) as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&debug(&$val) as &Value)) },
$next,
$($rest)*
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, $($k:ident).+ = %$val:expr, $($rest:tt)*) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$crate::field::display(&$val) as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&display(&$val) as &Value)) },
$next,
$($rest)*
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, $($k:ident).+ = $val:expr, $($rest:tt)*) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$val as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&$val as &Value)) },
$next,
$($rest)*
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, $($k:ident).+, $($rest:tt)*) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$($k).+ as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&$($k).+ as &Value)) },
$next,
$($rest)*
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, ?$($k:ident).+, $($rest:tt)*) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$crate::field::debug(&$($k).+) as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&debug(&$($k).+) as &Value)) },
$next,
$($rest)*
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, %$($k:ident).+, $($rest:tt)*) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$crate::field::display(&$($k).+) as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&display(&$($k).+) as &Value)) },
$next,
$($rest)*
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, $($k:ident).+ = ?$val:expr) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$crate::field::debug(&$val) as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&debug(&$val) as &Value)) },
$next,
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, $($k:ident).+ = %$val:expr) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$crate::field::display(&$val) as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&display(&$val) as &Value)) },
$next,
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, $($k:ident).+ = $val:expr) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$val as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&$val as &Value)) },
$next,
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, $($k:ident).+) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$($k).+ as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&$($k).+ as &Value)) },
$next,
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, ?$($k:ident).+) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$crate::field::debug(&$($k).+) as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&debug(&$($k).+) as &Value)) },
$next,
)
};
(@ { $(,)* $($out:expr),* }, $next:expr, %$($k:ident).+) => {
$crate::valueset!(
@ { $($out),*, (&$next, Some(&$crate::field::display(&$($k).+) as &$crate::field::Value)) },
@ { $($out),*, (&$next, Some(&display(&$($k).+) as &Value)) },
$next,
)
};
// Remainder is unparseable, but exists --- must be format args!
(@ { $(,)* $($out:expr),* }, $next:expr, $($rest:tt)+) => {
$crate::valueset!(@ { (&$next, Some(&format_args!($($rest)+) as &$crate::field::Value)), $($out),* }, $next, )
$crate::valueset!(@ { (&$next, Some(&format_args!($($rest)+) as &Value)), $($out),* }, $next, )
};

// === entry ===
($fields:expr, $($kvs:tt)+) => {
{
#[allow(unused_imports)]
use $crate::field::{debug, display, Value};
let mut iter = $fields.iter();
$fields.value_set($crate::valueset!(
@ { },
Expand Down

0 comments on commit 2feb61d

Please sign in to comment.