tracing: fix name clash inside of tracing macros #806
Conversation
This commit fixes name clashes that occured inside of tracing macros when values with the names display,Value,debug have been used.
There was a problem hiding this comment.
This change looks good to me.
If you like, I think it might be good to add the repro from #805 as a test to ensure that there aren't regressions in the future.
Also, a couple procedural notes: can we change the PR title to start with the crate that the change applies to (in this case, "tracing:") rather than "fix:", and add "Fixes #805" to the commit message somewhere? CONTRIBUTING.md has documentation on the preferred convention for commit message/PRs. Not a big deal, of course, just thought I'd mention.
I can do that. Should I just force-push the changes to this PR? Thanks for mentioning the contributions.md. I actually didn't see it 😄 |
mainrs
changed the title
mainrs
changed the title
|
You don't need to force push, just edit the PR name and description. We'll squash the whole PR down to one commit when merging. |
|
Done. |
This reverts commit e3b3a3a. This change was accidentally semver-incompatible, as user code was able to use the imported `debug` and `display` functions without adding an import outside the macro. Although this was not documented, downstream code relied on these names being available, so this resulted in a breaking change in a point release. Fixes #820
This reverts commit e3b3a3a. This change was accidentally semver-incompatible, as user code was able to use the imported `debug` and `display` functions without adding an import outside the macro. Although this was not documented, downstream code relied on these names being available, so this resulted in a breaking change in a point release. Fixes #820
This commit fixes name clashes that occurred inside of tracing macros when values with the names
display, Value and debughave been used.Motivation
This allows library users to trace variables that have the same name as imported types inside the
tracing::fieldmodule.Solution
Use fully qualified type names for types used inside the
tracing::fieldmodule.Related issues/PRs
Fixes #805.