test_python_sdist: run on release tags only #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjakubowski
force-pushed
the
sdist-ci-followups
branch
5 times, most recently
from
aab0b79 to
3a8506b
Compare
fixes bug when cmake is installed to a path with a space in it Signed-off-by: Tom Jakubowski <tom@prospective.dev>
Also updates the cargo patch-job so it uses the .crate files produced earlier in the workflow instead of using git sources with metadata. This is closer to what happens when building and installing from a release sdist, which pulls .crate files from crates.io. Signed-off-by: Tom Jakubowski <tom@prospective.dev>
Change how the CMAKE_C_FLAGS_RELEASE and CMAKE_CXX_FLAGS_RELEASE variables are reset and used. They are now interpolated into CMAKE_CXX_FLAGS, placed before the EXTENDED_FLAGS so that EXTENDED_FLAGS and OPT_FLAGS can override the FLAGS_RELEASE. This ensures that RELEASE flags from the environment are used, while allowing them to be overridden by perspective's optimization flags. Also preserve values of `CMAKE_CXX_FLAGS` set by the builder. This is a port of a conda-feedstock patch by Isuru Fernando. <conda-forge/perspective-feedstock@9eab18c> Signed-off-by: Tom Jakubowski <tom@prospective.dev>
Signed-off-by: Tom Jakubowski <tom@prospective.dev>
this was an ODR violation: the same function was defined twice, once with `inline` specifier in utils.h, and once without `inline` in utils.cpp it happened to work on clang and gcc and msvc, most of the time, but broke in the conda build on Windows Signed-off-by: Tom Jakubowski <tom@prospective.dev>
tomjakubowski
force-pushed
the
sdist-ci-followups
branch
2 times, most recently
from
172478a to
5b5f9ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updates the cargo patch-job so it uses the .crate files produced earlier in the workflow instead of using git sources with metadata. this is closer to what happens when installing a release version sdist (and would help us catch problems packaging the server and client crate sources)
Pull Request Checklist
Discussions, this PR applies to.