Fix logger initialization error in unit tests #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xternalStorageState() returning null
|
Hmm. This shouldn't be occurring. Are you using Robolectric as your test runner? |
|
The fix seems reasonable, so I'll certainly accept the PR. Looking forward to your response for clarity. |
|
No, the error occurs in regular unit tests which cover the business logic without dependencies on Android components. So I don't want to use Robolectric in this case, cause it significantly slows down the test initialization. |
|
I'm using |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment.getExternalStorageState() returns null in Unit Tests. Which causes and error in the logger initialization. This pull request fixes the issue.
