Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bootc support to redhat_upgrade #986

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

tulilirockz
Copy link
Contributor

@tulilirockz tulilirockz commented Nov 17, 2024

What does this PR do

This PR adds Bootc support for redhat_upgrade as they are going to ship this as the default starting with F42 Atomic AFAIK. It takes precedence over rpm-ostree if it is enabled.

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

@SteveLauC
Copy link
Member

Hi, in what distros, bootc will replace rpm-ostree? Topgrade also has a FedoraImmutable for those Fedora variants, I wonder if bootc will be used there as well🤔

@tulilirockz
Copy link
Contributor Author

tulilirockz commented Nov 18, 2024

Hi, in what distros, bootc will replace rpm-ostree? Topgrade also has a FedoraImmutable for those Fedora variants, I wonder if bootc will be used there as well🤔

In Fedora Silverblue/other atomic variants! https://docs.fedoraproject.org/en-US/bootc/getting-started/ (Technically you can already use it too! Pretty exciting right)

@tulilirockz
Copy link
Contributor Author

Ill be updating the Fedora Immutable part too

@tulilirockz
Copy link
Contributor Author

Bootc does not support package layering tho, so it should not be the default until DNF supports image-based systems layering

@tulilirockz tulilirockz force-pushed the main branch 3 times, most recently from 388fe06 to 81af887 Compare November 18, 2024 02:34
@tulilirockz
Copy link
Contributor Author

tulilirockz commented Nov 18, 2024

Works fine when using a configuration file like this one:

[misc]
only = ["system"]

[linux]
bootc = true
rpm_ostree = true # supercedes rpm-ostree when bootc is enabled

Output:

~/opt/topgrade> cargo run -- --config ./test.config.toml
   Compiling topgrade v16.0.1 (/var/home/tulili/opt/topgrade)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.04s
     Running `target/debug/topgrade --config ./test.config.toml`

── 23:38:12 - System update ────────────────────────────────────────────────────
No changes in ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:latest => sha256:47f4c91dda60b6cfe90e14b39a5539d9ffbb72304776ac64a919e6186de9c1c5
No update available.

── 23:38:15 - Summary ──────────────────────────────────────────────────────────
System update: OK

config.example.toml Outdated Show resolved Hide resolved
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC merged commit 4f4dcbb into topgrade-rs:main Nov 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants