Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont ignore rpm-ostree when bootc is found #999

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

befanyt
Copy link
Contributor

@befanyt befanyt commented Dec 9, 2024

What does this PR do

This PR should fix #997 where it wouldn't take the rpm-ostree flow when bootc was found on the system, even if it was disabled via the config.

Tested with rpm-ostree=false & bootc=false it used dnf
Tested with rpm-ostree=true & bootc=false it used rpm-ostree
Tested with rpm-ostree=false & bootc=true it used bootc

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

This was introducued in PR #986
@tulilirockz maybe you can verify this also works for you.

@SteveLauC SteveLauC self-requested a review December 10, 2024 01:28
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing it! Also for the thorough tests!

@SteveLauC SteveLauC merged commit a0963fe into topgrade-rs:main Dec 10, 2024
12 checks passed
@befanyt befanyt deleted the bootc-rpmostree branch December 10, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootc exists on system but disabled via config will ignore rpm-ostree
3 participants