Merge pull request #1 from torvalds/master #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello,world!
krzk
pushed a commit
to krzk/linux
that referenced
this pull request
May 15, 2017
WARNING: line over 80 characters torvalds#353: FILE: drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:704: + REFILL_BUFFER_SIZE * omap_dmm->num_engines, ERROR: code indent should use tabs where possible torvalds#557: FILE: drivers/gpu/host1x/job.c:581: +^I^I job->gather_copy_mapped, job->gather_copy);$ ERROR: code indent should use tabs where possible torvalds#925: FILE: drivers/video/fbdev/s3c-fb.c:1134: +^I^I fbi->screen_base, fbi->fix.smem_start);$ total: 2 errors, 1 warnings, 867 lines checked NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile ./patches/dma-rename-dma__writecombine-to-dma__wc.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Luis R. Rodriguez" <mcgrof@suse.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tobetter
added a commit
to tobetter/linux
that referenced
this pull request
Jul 2, 2018
ODROID: net/usb: updating ASIX AX88179_178A network driver
tobetter
added a commit
to tobetter/linux
that referenced
this pull request
Jul 2, 2018
This commit is to add missing header file 'drivers/net/usb/ax88179_178a.h' from the pull request torvalds#353, hardkernel#353 Change-Id: I48cebb977e4fda437eebd62d4cee65adf6e41ed6 Signed-off-by: Dongjin Kim <tobetter@gmail.com>
Mic92
pushed a commit
to Mic92/linux
that referenced
this pull request
Feb 4, 2019
make 'encode_dev_from_sysfs' a public library function
commodo
added a commit
to commodo/linux
that referenced
this pull request
May 22, 2019
…018.3 master: update with xilinx-v2018.3 release tag The testing has been finalized on the HDL side. The code from xilinx-v2018.3 release tag has also been validated. The only major highlight for this change (other than Xilinx patches) is this patch 1f47ad4 ("serial: uartlite: fix null dereference on probe error path") which was also sent to Xilinx and applied to their master. Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 15, 2021
This commit fixes the following checkpatch.pl errors:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#285: FILE: ./hal/odm.c:285:
+void odm_CommonInfoSelfInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#287: FILE: ./hal/odm.c:287:
+void odm_CommonInfoSelfUpdate(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#289: FILE: ./hal/odm.c:289:
+void odm_CmnInfoInit_Debug(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#291: FILE: ./hal/odm.c:291:
+void odm_BasicDbgMessage(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#305: FILE: ./hal/odm.c:305:
+void odm_RefreshRateAdaptiveMaskCE(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#309: FILE: ./hal/odm.c:309:
+void odm_RSSIMonitorInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#311: FILE: ./hal/odm.c:311:
+void odm_RSSIMonitorCheckCE(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#313: FILE: ./hal/odm.c:313:
+void odm_RSSIMonitorCheck(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#315: FILE: ./hal/odm.c:315:
+void odm_SwAntDetectInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#323: FILE: ./hal/odm.c:323:
+void odm_RefreshRateAdaptiveMask(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#325: FILE: ./hal/odm.c:325:
+void ODM_TXPowerTrackingCheck(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#327: FILE: ./hal/odm.c:327:
+void odm_RateAdaptiveMaskInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#330: FILE: ./hal/odm.c:330:
+void odm_TXPowerTrackingInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#338: FILE: ./hal/odm.c:338:
+void odm_InitHybridAntDiv(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#341: FILE: ./hal/odm.c:341:
+ struct DM_ODM_T * pDM_Odm,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#349: FILE: ./hal/odm.c:349:
+void odm_SetRxIdleAnt(struct DM_ODM_T * pDM_Odm, u8 Ant, bool bDualPath);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#353: FILE: ./hal/odm.c:353:
+void odm_HwAntDiv(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#363: FILE: ./hal/odm.c:363:
+void ODM_DMInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#393: FILE: ./hal/odm.c:393:
+void ODM_DMWatchdog(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#420: FILE: ./hal/odm.c:420:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#448: FILE: ./hal/odm.c:448:
+void ODM_CmnInfoInit(struct DM_ODM_T * pDM_Odm, enum ODM_CMNINFO_E CmnInfo, u32 Value)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#560: FILE: ./hal/odm.c:560:
+void ODM_CmnInfoHook(struct DM_ODM_T * pDM_Odm, enum ODM_CMNINFO_E CmnInfo, void *pValue)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#689: FILE: ./hal/odm.c:689:
+ struct DM_ODM_T * pDM_Odm,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#717: FILE: ./hal/odm.c:717:
+void ODM_CmnInfoUpdate(struct DM_ODM_T * pDM_Odm, u32 CmnInfo, u64 Value)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#831: FILE: ./hal/odm.c:831:
+void odm_CommonInfoSelfInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#841: FILE: ./hal/odm.c:841:
+void odm_CommonInfoSelfUpdate(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#867: FILE: ./hal/odm.c:867:
+void odm_CmnInfoInit_Debug(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#888: FILE: ./hal/odm.c:888:
+void odm_BasicDbgMessage(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#935: FILE: ./hal/odm.c:935:
+void odm_RateAdaptiveMaskInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#937: FILE: ./hal/odm.c:937:
+ struct ODM_RATE_ADAPTIVE * pOdmRA = &pDM_Odm->RateAdaptive;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#953: FILE: ./hal/odm.c:953:
+ struct DM_ODM_T * pDM_Odm,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1083: FILE: ./hal/odm.c:1083:
+void odm_RefreshRateAdaptiveMask(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1094: FILE: ./hal/odm.c:1094:
+void odm_RefreshRateAdaptiveMaskCE(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1131: FILE: ./hal/odm.c:1131:
+ struct DM_ODM_T * pDM_Odm,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1137: FILE: ./hal/odm.c:1137:
+ struct ODM_RATE_ADAPTIVE * pRA = &pDM_Odm->RateAdaptive;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1196: FILE: ./hal/odm.c:1196:
+void odm_RSSIMonitorInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1198: FILE: ./hal/odm.c:1198:
+ struct RA_T * pRA_Table = &pDM_Odm->DM_RA_Table;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1204: FILE: ./hal/odm.c:1204:
+void odm_RSSIMonitorCheck(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1217: FILE: ./hal/odm.c:1217:
+ struct DM_ODM_T * pDM_Odm = &(pHalData->odmpriv);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1234: FILE: ./hal/odm.c:1234:
+void odm_RSSIMonitorCheckCE(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1243: FILE: ./hal/odm.c:1243:
+ struct RA_T * pRA_Table = &pDM_Odm->DM_RA_Table;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1306: FILE: ./hal/odm.c:1306:
+static u8 getSwingIndex(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1330: FILE: ./hal/odm.c:1330:
+void odm_TXPowerTrackingInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1374: FILE: ./hal/odm.c:1374:
+void ODM_TXPowerTrackingCheck(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1398: FILE: ./hal/odm.c:1398:
+void odm_SwAntDetectInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1400: FILE: ./hal/odm.c:1400:
+ struct SWAT_T * pDM_SWAT_Table = &pDM_Odm->DM_SWAT_Table;
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
fengguang
pushed a commit
to 0day-ci/linux
that referenced
this pull request
Mar 16, 2021
This commit fixes the following checkpatch.pl errors:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#285: FILE: ./hal/odm.c:285:
+void odm_CommonInfoSelfInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#287: FILE: ./hal/odm.c:287:
+void odm_CommonInfoSelfUpdate(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#289: FILE: ./hal/odm.c:289:
+void odm_CmnInfoInit_Debug(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#291: FILE: ./hal/odm.c:291:
+void odm_BasicDbgMessage(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#305: FILE: ./hal/odm.c:305:
+void odm_RefreshRateAdaptiveMaskCE(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#309: FILE: ./hal/odm.c:309:
+void odm_RSSIMonitorInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#311: FILE: ./hal/odm.c:311:
+void odm_RSSIMonitorCheckCE(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#313: FILE: ./hal/odm.c:313:
+void odm_RSSIMonitorCheck(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#315: FILE: ./hal/odm.c:315:
+void odm_SwAntDetectInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#323: FILE: ./hal/odm.c:323:
+void odm_RefreshRateAdaptiveMask(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#325: FILE: ./hal/odm.c:325:
+void ODM_TXPowerTrackingCheck(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#327: FILE: ./hal/odm.c:327:
+void odm_RateAdaptiveMaskInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#330: FILE: ./hal/odm.c:330:
+void odm_TXPowerTrackingInit(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#338: FILE: ./hal/odm.c:338:
+void odm_InitHybridAntDiv(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#341: FILE: ./hal/odm.c:341:
+ struct DM_ODM_T * pDM_Odm,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#349: FILE: ./hal/odm.c:349:
+void odm_SetRxIdleAnt(struct DM_ODM_T * pDM_Odm, u8 Ant, bool bDualPath);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#353: FILE: ./hal/odm.c:353:
+void odm_HwAntDiv(struct DM_ODM_T * pDM_Odm);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#363: FILE: ./hal/odm.c:363:
+void ODM_DMInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#393: FILE: ./hal/odm.c:393:
+void ODM_DMWatchdog(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#420: FILE: ./hal/odm.c:420:
+ struct DIG_T * pDM_DigTable = &pDM_Odm->DM_DigTable;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#448: FILE: ./hal/odm.c:448:
+void ODM_CmnInfoInit(struct DM_ODM_T * pDM_Odm, enum ODM_CMNINFO_E CmnInfo, u32 Value)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#560: FILE: ./hal/odm.c:560:
+void ODM_CmnInfoHook(struct DM_ODM_T * pDM_Odm, enum ODM_CMNINFO_E CmnInfo, void *pValue)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#689: FILE: ./hal/odm.c:689:
+ struct DM_ODM_T * pDM_Odm,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#717: FILE: ./hal/odm.c:717:
+void ODM_CmnInfoUpdate(struct DM_ODM_T * pDM_Odm, u32 CmnInfo, u64 Value)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#831: FILE: ./hal/odm.c:831:
+void odm_CommonInfoSelfInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#841: FILE: ./hal/odm.c:841:
+void odm_CommonInfoSelfUpdate(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#867: FILE: ./hal/odm.c:867:
+void odm_CmnInfoInit_Debug(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#888: FILE: ./hal/odm.c:888:
+void odm_BasicDbgMessage(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#935: FILE: ./hal/odm.c:935:
+void odm_RateAdaptiveMaskInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#937: FILE: ./hal/odm.c:937:
+ struct ODM_RATE_ADAPTIVE * pOdmRA = &pDM_Odm->RateAdaptive;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#953: FILE: ./hal/odm.c:953:
+ struct DM_ODM_T * pDM_Odm,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1083: FILE: ./hal/odm.c:1083:
+void odm_RefreshRateAdaptiveMask(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
torvalds#1094: FILE: ./hal/odm.c:1094:
+void odm_RefreshRateAdaptiveMaskCE(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1131: FILE: ./hal/odm.c:1131:
+ struct DM_ODM_T * pDM_Odm,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1137: FILE: ./hal/odm.c:1137:
+ struct ODM_RATE_ADAPTIVE * pRA = &pDM_Odm->RateAdaptive;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1196: FILE: ./hal/odm.c:1196:
+void odm_RSSIMonitorInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1198: FILE: ./hal/odm.c:1198:
+ struct RA_T * pRA_Table = &pDM_Odm->DM_RA_Table;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1204: FILE: ./hal/odm.c:1204:
+void odm_RSSIMonitorCheck(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1217: FILE: ./hal/odm.c:1217:
+ struct DM_ODM_T * pDM_Odm = &(pHalData->odmpriv);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1234: FILE: ./hal/odm.c:1234:
+void odm_RSSIMonitorCheckCE(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1243: FILE: ./hal/odm.c:1243:
+ struct RA_T * pRA_Table = &pDM_Odm->DM_RA_Table;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1306: FILE: ./hal/odm.c:1306:
+static u8 getSwingIndex(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1330: FILE: ./hal/odm.c:1330:
+void odm_TXPowerTrackingInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1374: FILE: ./hal/odm.c:1374:
+void ODM_TXPowerTrackingCheck(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1398: FILE: ./hal/odm.c:1398:
+void odm_SwAntDetectInit(struct DM_ODM_T * pDM_Odm)
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1400: FILE: ./hal/odm.c:1400:
+ struct SWAT_T * pDM_SWAT_Table = &pDM_Odm->DM_SWAT_Table;
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marco Cesati <marcocesati@gmail.com>
Link: https://lore.kernel.org/r/20210315170618.2566-21-marcocesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,world!