Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3 documentation is incorrect and exposes inexperienced users by introducing security risk #3565

Closed
SleeplessByte opened this issue Mar 13, 2022 · 1 comment · Fixed by #3571
Assignees
Labels

Comments

@SleeplessByte
Copy link

b03613d
b03613d#commitcomment-68591568

This documentation change is incorrect. There is no second layer of security, and turning off the "block" will make "it work" because you're literally saying to remove access control. This has been in the docs for three years, and apparently people are following this advice, but it's not necessary (and incorrect).

Further git blame shows that the author had not set up CORS correctly in the first place: de9effd, which is likely what led to the 403s.
For future reference, please don't write instructions that are unverified, based on a hunch, as if they're facts.

I recommend reverting this commit (but keeping the second one, because that one is correct), and perhaps adding some sort of guidline to CONTRIBUTING.md. Claims like this should at least be covered by a platform (AWS) doc or forum post.

@mifi
Copy link
Contributor

mifi commented Mar 15, 2022

Thanks for reporting this! I have tested s3 without public access and it still works. So you are absolutely right. This documentation change was a mistake. I will create a PR with the suggested improvements.

mifi added a commit that referenced this issue Mar 15, 2022
mifi added a commit that referenced this issue Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants