Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/thumbnail-generator: migrate to TS #4978

Merged
merged 4 commits into from
Mar 7, 2024
Merged

@uppy/thumbnail-generator: migrate to TS #4978

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46b4da6
@uppy/thumbnail-generator: migrate to TS
Murderlon Feb 29, 2024
3fbb4b8
revert regression
aduh95 Mar 7, 2024
5e7bff0
add TSFixMe type
aduh95 Mar 7, 2024
a31056c
Revert "add TSFixMe type"
Murderlon Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@uppy/thumbnail-generator/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
tsconfig.*
2 changes: 1 addition & 1 deletion packages/@uppy/thumbnail-generator/src/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { afterEach, beforeEach, describe, it, expect, vi } from 'vitest'
import { UIPlugin } from '@uppy/core'
import emitter from 'namespace-emitter'
import ThumbnailGeneratorPlugin from './index.js'
import ThumbnailGeneratorPlugin from './index.ts'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of tricky things from a type perspective in this test file. Needed a lot of type hacks, or any's, or ignore to make it work so decided to keep it JS.


const delay = duration => new Promise(resolve => setTimeout(resolve, duration))

Expand Down
Loading
Loading