@uppy/thumbnail-generator: migrate to TS

[Murderlon]

No description provided.

[github-actions]

Diff output files

diff --git a/packages/@uppy/thumbnail-generator/lib/index.js b/packages/@uppy/thumbnail-generator/lib/index.js
index b2e9a5b..2d31115 100644
--- a/packages/@uppy/thumbnail-generator/lib/index.js
+++ b/packages/@uppy/thumbnail-generator/lib/index.js
@@ -76,9 +76,19 @@ function protect(image) {
   }
   return image;
 }
+const defaultOptions = {
+  thumbnailWidth: null,
+  thumbnailHeight: null,
+  thumbnailType: "image/jpeg",
+  waitForThumbnailsBeforeUpload: false,
+  lazy: false,
+};
 export default class ThumbnailGenerator extends UIPlugin {
   constructor(uppy, opts) {
-    super(uppy, opts);
+    super(uppy, {
+      ...defaultOptions,
+      ...opts,
+    });
     this.onFileAdded = file => {
       if (!file.preview && file.data && isPreviewSupported(file.type) && !file.isRemote) {
         this.addToQueue(file.id);
@@ -142,18 +152,8 @@ export default class ThumbnailGenerator extends UIPlugin {
     this.queue = [];
     this.queueProcessing = false;
     this.defaultThumbnailDimension = 200;
-    this.thumbnailType = this.opts.thumbnailType || "image/jpeg";
+    this.thumbnailType = this.opts.thumbnailType;
     this.defaultLocale = locale;
-    const defaultOptions = {
-      thumbnailWidth: null,
-      thumbnailHeight: null,
-      waitForThumbnailsBeforeUpload: false,
-      lazy: false,
-    };
-    this.opts = {
-      ...defaultOptions,
-      ...opts,
-    };
     this.i18nInit();
     if (this.opts.lazy && this.opts.waitForThumbnailsBeforeUpload) {
       throw new Error(
@@ -186,9 +186,9 @@ export default class ThumbnailGenerator extends UIPlugin {
       return URL.createObjectURL(blob);
     });
   }
-  getProportionalDimensions(img, width, height, rotation) {
+  getProportionalDimensions(img, width, height, deg) {
     let aspect = img.width / img.height;
-    if (rotation === 90 || rotation === 270) {
+    if (deg === 90 || deg === 270) {
       aspect = img.height / img.width;
     }
     if (width != null) {
@@ -233,8 +233,8 @@ export default class ThumbnailGenerator extends UIPlugin {
       preview,
     });
   }
-  addToQueue(item) {
-    this.queue.push(item);
+  addToQueue(fileID) {
+    this.queue.push(fileID);
     if (this.queueProcessing === false) {
       this.processQueue();
     }

[Murderlon]

Lots of tricky things from a type perspective in this test file. Needed a lot of type hacks, or any's, or ignore to make it work so decided to keep it JS.

[Murderlon]

I don't agree with this $TSFIXME "fix". No one benefits from these complex deprecated event types, they aren't published, and never will be (I'm going to remove them for 4.0). In the meantime every single .on in the codebase doesn't work, many type checks that could go wrong.

Let's make on simple.

[aduh95]

every single .on in the codebase doesn't work, many type checks that could go wrong.

That's not true though, it works everywhere except here (probably because we define thumbnail:request twice?) I agree it doesn't matter too much