Make allowedMetaFields consistent

[Murderlon]

Closes #4217

It's now always boolean | string[], with true as default which sends all meta fields.

[github-actions]

Diff output files

diff --git a/packages/@uppy/aws-s3-multipart/lib/index.js b/packages/@uppy/aws-s3-multipart/lib/index.js
index 70d6f5b..4faed3f 100644
--- a/packages/@uppy/aws-s3-multipart/lib/index.js
+++ b/packages/@uppy/aws-s3-multipart/lib/index.js
@@ -14,6 +14,7 @@ import BasePlugin from "@uppy/core/lib/BasePlugin.js";
 import EventManager from "@uppy/core/lib/EventManager.js";
 import { createAbortError } from "@uppy/utils/lib/AbortController";
 import { filterFilesToEmitUploadStarted, filterNonFailedFiles } from "@uppy/utils/lib/fileFilters";
+import getAllowedMetaFields from "@uppy/utils/lib/getAllowedMetaFields";
 import { RateLimitedQueue } from "@uppy/utils/lib/RateLimitedQueue";
 import createSignedURL from "./createSignedURL.js";
 import { HTTPCommunicationQueue } from "./HTTPCommunicationQueue.js";
@@ -57,7 +58,7 @@ function getAllowedMetadata(_ref) {
   );
 }
 const defaultOptions = {
-  allowedMetaFields: null,
+  allowedMetaFields: true,
   limit: 6,
   getTemporarySecurityCredentials: false,
   shouldUseMultipart: file => file.size !== 0,
@@ -299,9 +300,10 @@ export default class AwsS3Multipart extends BasePlugin {
   createMultipartUpload(file, signal) {
     this.assertHost("createMultipartUpload");
     throwIfAborted(signal);
+    const allowedMetaFields = getAllowedMetaFields(this.opts.allowedMetaFields, file.meta);
     const metadata = getAllowedMetadata({
       meta: file.meta,
-      allowedMetaFields: this.opts.allowedMetaFields,
+      allowedMetaFields,
     });
     return _classPrivateFieldLooseBase(this, _client)[_client].post("s3/multipart", {
       filename: file.name,
@@ -425,9 +427,10 @@ export default class AwsS3Multipart extends BasePlugin {
       type,
       name: filename,
     } = meta;
+    const allowedMetaFields = getAllowedMetaFields(this.opts.allowedMetaFields, file.meta);
     const metadata = getAllowedMetadata({
       meta,
-      allowedMetaFields: this.opts.allowedMetaFields,
+      allowedMetaFields,
       querify: true,
     });
     const query = new URLSearchParams({
diff --git a/packages/@uppy/tus/lib/index.js b/packages/@uppy/tus/lib/index.js
index dfa1bd1..23a9e87 100644
--- a/packages/@uppy/tus/lib/index.js
+++ b/packages/@uppy/tus/lib/index.js
@@ -11,6 +11,7 @@ function _classPrivateFieldLooseKey(name) {
 import BasePlugin from "@uppy/core/lib/BasePlugin.js";
 import EventManager from "@uppy/core/lib/EventManager.js";
 import { filterFilesToEmitUploadStarted, filterNonFailedFiles } from "@uppy/utils/lib/fileFilters";
+import getAllowedMetaFields from "@uppy/utils/lib/getAllowedMetaFields";
 import hasProperty from "@uppy/utils/lib/hasProperty";
 import isNetworkError from "@uppy/utils/lib/isNetworkError";
 import NetworkError from "@uppy/utils/lib/NetworkError";
@@ -43,6 +44,7 @@ const defaultOptions = {
   limit: 20,
   retryDelays: tusDefaultOptions.retryDelays,
   withCredentials: false,
+  allowedMetaFields: true,
 };
 var _retryDelayIterator = _classPrivateFieldLooseKey("retryDelayIterator");
 var _uploadLocalFile = _classPrivateFieldLooseKey("uploadLocalFile");
@@ -328,7 +330,7 @@ function _uploadLocalFile2(file) {
       }
     };
     const meta = {};
-    const allowedMetaFields = Array.isArray(opts.allowedMetaFields) ? opts.allowedMetaFields : Object.keys(file.meta);
+    const allowedMetaFields = getAllowedMetaFields(opts.allowedMetaFields, file.meta);
     allowedMetaFields.forEach(item => {
       meta[item] = String(file.meta[item]);
     });
diff --git a/packages/@uppy/xhr-upload/lib/index.js b/packages/@uppy/xhr-upload/lib/index.js
index 609c3ad..0a6a698 100644
--- a/packages/@uppy/xhr-upload/lib/index.js
+++ b/packages/@uppy/xhr-upload/lib/index.js
@@ -11,6 +11,7 @@ function _classPrivateFieldLooseKey(name) {
 import BasePlugin from "@uppy/core/lib/BasePlugin.js";
 import EventManager from "@uppy/core/lib/EventManager.js";
 import { filterFilesToEmitUploadStarted, filterNonFailedFiles } from "@uppy/utils/lib/fileFilters";
+import getAllowedMetaFields from "@uppy/utils/lib/getAllowedMetaFields";
 import isNetworkError from "@uppy/utils/lib/isNetworkError";
 import NetworkError from "@uppy/utils/lib/NetworkError";
 import ProgressTimeout from "@uppy/utils/lib/ProgressTimeout";
@@ -44,7 +45,7 @@ const defaultOptions = {
   formData: true,
   fieldName: "file",
   method: "post",
-  allowedMetaFields: null,
+  allowedMetaFields: true,
   responseUrlFieldName: "url",
   bundle: false,
   headers: {},
@@ -171,7 +172,7 @@ export default class XHRUpload extends BasePlugin {
     return opts;
   }
   addMetadata(formData, meta, opts) {
-    const allowedMetaFields = Array.isArray(opts.allowedMetaFields) ? opts.allowedMetaFields : Object.keys(meta);
+    const allowedMetaFields = getAllowedMetaFields(opts.allowedMetaFields, meta);
     allowedMetaFields.forEach(item => {
       const value = meta[item];
       if (Array.isArray(value)) {
@@ -432,7 +433,7 @@ function _uploadBundle2(files) {
 function _getCompanionClientArgs2(file) {
   var _file$remote;
   const opts = this.getOptions(file);
-  const allowedMetaFields = Array.isArray(opts.allowedMetaFields) ? opts.allowedMetaFields : Object.keys(file.meta);
+  const allowedMetaFields = getAllowedMetaFields(opts.allowedMetaFields, file.meta);
   return {
     ...((_file$remote = file.remote) == null ? void 0 : _file$remote.body),
     protocol: "multipart",

[Murderlon]

@SocketSecurity ignore-all

[aduh95]

LGTM, we have to remember to update the docs at some point.

You'll have to rebase to modify the index.ts instead of index.js for AWS plugin.