@uppy/image-editor: fix label definitions

[aduh95]

Trying to upgrade our deps reveals a new lint errors: we should be applying the label to the <button> elements, not the <label> ones.

[github-actions]

Diff output files

diff --git a/packages/@uppy/image-editor/lib/Editor.js b/packages/@uppy/image-editor/lib/Editor.js
index 4d3030d..4a372db 100644
--- a/packages/@uppy/image-editor/lib/Editor.js
+++ b/packages/@uppy/image-editor/lib/Editor.js
@@ -121,7 +121,6 @@ export default class Editor extends Component {
       "label",
       {
         role: "tooltip",
-        "aria-label": i18n("revert"),
         "data-microtip-position": "top",
       },
       h(
@@ -129,6 +128,7 @@ export default class Editor extends Component {
         {
           type: "button",
           className: "uppy-u-reset uppy-c-btn",
+          "aria-label": i18n("revert"),
           onClick: () => {
             this.cropper.reset();
             this.cropper.setAspectRatio(opts.cropperOptions.initialAspectRatio);
@@ -166,7 +166,6 @@ export default class Editor extends Component {
       "label",
       {
         role: "tooltip",
-        "aria-label": i18n("rotate"),
         "data-microtip-position": "top",
       },
       h(
@@ -174,6 +173,7 @@ export default class Editor extends Component {
         {
           type: "button",
           className: "uppy-u-reset uppy-c-btn",
+          "aria-label": i18n("rotate"),
           onClick: this.onRotate90Deg,
         },
         h(
@@ -204,7 +204,6 @@ export default class Editor extends Component {
       "label",
       {
         role: "tooltip",
-        "aria-label": i18n("flipHorizontal"),
         "data-microtip-position": "top",
       },
       h(
@@ -212,6 +211,7 @@ export default class Editor extends Component {
         {
           type: "button",
           className: "uppy-u-reset uppy-c-btn",
+          "aria-label": i18n("flipHorizontal"),
           onClick: () => this.cropper.scaleX(-this.cropper.getData().scaleX || -1),
         },
         h(
@@ -242,7 +242,6 @@ export default class Editor extends Component {
       "label",
       {
         role: "tooltip",
-        "aria-label": i18n("zoomIn"),
         "data-microtip-position": "top",
       },
       h(
@@ -250,6 +249,7 @@ export default class Editor extends Component {
         {
           type: "button",
           className: "uppy-u-reset uppy-c-btn",
+          "aria-label": i18n("zoomIn"),
           onClick: () => this.cropper.zoom(0.1),
         },
         h(
@@ -283,7 +283,6 @@ export default class Editor extends Component {
       "label",
       {
         role: "tooltip",
-        "aria-label": i18n("zoomOut"),
         "data-microtip-position": "top",
       },
       h(
@@ -291,6 +290,7 @@ export default class Editor extends Component {
         {
           type: "button",
           className: "uppy-u-reset uppy-c-btn",
+          "aria-label": i18n("zoomOut"),
           onClick: () => this.cropper.zoom(-0.1),
         },
         h(
@@ -321,7 +321,6 @@ export default class Editor extends Component {
       "label",
       {
         role: "tooltip",
-        "aria-label": i18n("aspectRatioSquare"),
         "data-microtip-position": "top",
       },
       h(
@@ -329,6 +328,7 @@ export default class Editor extends Component {
         {
           type: "button",
           className: "uppy-u-reset uppy-c-btn",
+          "aria-label": i18n("aspectRatioSquare"),
           onClick: () => this.cropper.setAspectRatio(1),
         },
         h(
@@ -359,7 +359,6 @@ export default class Editor extends Component {
       "label",
       {
         role: "tooltip",
-        "aria-label": i18n("aspectRatioLandscape"),
         "data-microtip-position": "top",
       },
       h(
@@ -367,6 +366,7 @@ export default class Editor extends Component {
         {
           type: "button",
           className: "uppy-u-reset uppy-c-btn",
+          "aria-label": i18n("aspectRatioLandscape"),
           onClick: () => this.cropper.setAspectRatio(16 / 9),
         },
         h(
@@ -397,13 +397,13 @@ export default class Editor extends Component {
       "label",
       {
         role: "tooltip",
-        "aria-label": i18n("aspectRatioPortrait"),
         "data-microtip-position": "top",
       },
       h(
         "button",
         {
           type: "button",
+          "aria-label": i18n("aspectRatioPortrait"),
           className: "uppy-u-reset uppy-c-btn",
           onClick: () => this.cropper.setAspectRatio(9 / 16),
         },

[avneetmalhotra]

@aduh95 Based on the changes on this PR, the tooltips has stopped working. Please check this PR fix that I have raised - #5156.
Please review and let me know if I need to change anything. Thanks