@uppy/core: reference updated i18n in Restricter

[Murderlon]

Fixes: #5115

The code isn't pretty and in hindsight I regret making Restricter a class rather than just a series of functions outside of core. But it is what it is now.

[github-actions]

Diff output files

diff --git a/packages/@uppy/core/lib/Restricter.js b/packages/@uppy/core/lib/Restricter.js
index 3174ead..7a5ac8b 100644
--- a/packages/@uppy/core/lib/Restricter.js
+++ b/packages/@uppy/core/lib/Restricter.js
@@ -23,8 +23,8 @@ class RestrictionError extends Error {
   }
 }
 class Restricter {
-  constructor(getOpts, i18n) {
-    this.i18n = i18n;
+  constructor(getOpts, getI18n) {
+    this.getI18n = getI18n;
     this.getOpts = () => {
       var _opts$restrictions;
       const opts = getOpts();
@@ -46,7 +46,7 @@ class Restricter {
       const nonGhostFiles = existingFiles.filter(f => !f.isGhost);
       if (nonGhostFiles.length + addingFiles.length > maxNumberOfFiles) {
         throw new RestrictionError(`${
-          this.i18n("youCanOnlyUploadX", {
+          this.getI18n()("youCanOnlyUploadX", {
             smart_count: maxNumberOfFiles,
           })
         }`);
@@ -61,10 +61,12 @@ class Restricter {
         if (addingFile.size != null) {
           totalFilesSize += addingFile.size;
           if (totalFilesSize > maxTotalFileSize) {
-            throw new RestrictionError(this.i18n("exceedsSize", {
-              size: prettierBytes(maxTotalFileSize),
-              file: addingFile.name,
-            }));
+            throw new RestrictionError(
+              this.getI18n()("exceedsSize", {
+                size: prettierBytes(maxTotalFileSize),
+                file: addingFile.name,
+              }),
+            );
           }
         }
       }
@@ -90,7 +92,7 @@ class Restricter {
       if (!isCorrectFileType) {
         const allowedFileTypesString = allowedFileTypes.join(", ");
         throw new RestrictionError(
-          this.i18n("youCanOnlyUploadFileTypes", {
+          this.getI18n()("youCanOnlyUploadFileTypes", {
             types: allowedFileTypesString,
           }),
           {
@@ -101,7 +103,7 @@ class Restricter {
     }
     if (maxFileSize && file.size != null && file.size > maxFileSize) {
       throw new RestrictionError(
-        this.i18n("exceedsSize", {
+        this.getI18n()("exceedsSize", {
           size: prettierBytes(maxFileSize),
           file: file.name,
         }),
@@ -112,7 +114,7 @@ class Restricter {
     }
     if (minFileSize && file.size != null && file.size < minFileSize) {
       throw new RestrictionError(
-        this.i18n("inferiorSize", {
+        this.getI18n()("inferiorSize", {
           size: prettierBytes(minFileSize),
         }),
         {
@@ -132,15 +134,19 @@ class Restricter {
       minNumberOfFiles,
     } = this.getOpts().restrictions;
     if (minNumberOfFiles && Object.keys(files).length < minNumberOfFiles) {
-      throw new RestrictionError(this.i18n("youHaveToAtLeastSelectX", {
-        smart_count: minNumberOfFiles,
-      }));
+      throw new RestrictionError(
+        this.getI18n()("youHaveToAtLeastSelectX", {
+          smart_count: minNumberOfFiles,
+        }),
+      );
     }
   }
   getMissingRequiredMetaFields(file) {
-    const error = new RestrictionError(this.i18n("missingRequiredMetaFieldOnFile", {
-      fileName: file.name,
-    }));
+    const error = new RestrictionError(
+      this.getI18n()("missingRequiredMetaFieldOnFile", {
+        fileName: file.name,
+      }),
+    );
     const {
       requiredMetaFields,
     } = this.getOpts().restrictions;
diff --git a/packages/@uppy/core/lib/Uppy.js b/packages/@uppy/core/lib/Uppy.js
index 737172d..0183757 100644
--- a/packages/@uppy/core/lib/Uppy.js
+++ b/packages/@uppy/core/lib/Uppy.js
@@ -209,7 +209,7 @@ export class Uppy {
       },
       info: [],
     });
-    _classPrivateFieldLooseBase(this, _restricter)[_restricter] = new Restricter(() => this.opts, this.i18n);
+    _classPrivateFieldLooseBase(this, _restricter)[_restricter] = new Restricter(() => this.opts, () => this.i18n);
     _classPrivateFieldLooseBase(this, _storeUnsubscribe)[_storeUnsubscribe] = this.store.subscribe(
       (prevState, nextState, patch) => {
         this.emit("state-update", prevState, nextState, patch);