Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip archiving in Glue an old table version during a table update operation #19739

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

findinpath
Copy link
Contributor

Description

Slack discussion: https://trinodb.slack.com/archives/CJ6UC075E/p1699927658771409

Additional context and related issues

#14336

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Nov 14, 2023
@github-actions github-actions bot added the iceberg Iceberg connector label Nov 14, 2023
@findepi
Copy link
Member

findepi commented Nov 14, 2023

TestIcebergGlueCatalogSkipArchive is now perhaps redundant

…ration

Skip archiving old table version when committing a table in Iceberg
in order to avoid potentially reaching Glue table version quotas.
@findinpath findinpath force-pushed the findinpath/iceberg-skip-archive branch from 175fa8a to 6fd49b8 Compare November 15, 2023 05:00
@github-actions github-actions bot added the docs label Nov 15, 2023
@findinpath
Copy link
Contributor Author

@ebyhr / @findepi pls run the PR with secrets.

@ebyhr
Copy link
Member

ebyhr commented Nov 15, 2023

/test-with-secrets sha=6fd49b892734f5b3d8c6a8f9602a033a14993e34

Copy link

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6873151431

@ebyhr ebyhr merged commit f4927c5 into trinodb:master Nov 15, 2023
47 checks passed
@github-actions github-actions bot added this to the 434 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants