[AMD]Enable EmitIndicesTest #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is created to discuss a proper way of enabling EmitIndicesTest for AMD target |
ThomasRaoux
reviewed
Feb 22, 2024
Comment on lines
75
to
79
| #ifdef USE_ROCM | ||
| amdHelper.emitIndices( | ||
| #else | ||
| emitIndices( | ||
| #endif |
There was a problem hiding this comment.
that kind of code is not going to be maintainable. Can you refactor this code to layer things properly, either pass different parameters or use inheritance to be able to control to call different backends.
There was a problem hiding this comment.
@ThomasRaoux , Is #ifdef USE_ROCM a red flag to decline merging? should I get rid of them?
There was a problem hiding this comment.
So, using #ifdef USE_ROCM is a definitely a wrong way. I've introduced new directives and build different targets for Nvidia and AMD.
Unfortunately some of the tests are failed, so I disabled them. Please take a look
joviliast
force-pushed
the
emitidx-test
branch
4 times, most recently
from
145f56f to
b1a617e
Compare
joviliast
force-pushed
the
emitidx-test
branch
2 times, most recently
from
842d5c4 to
ebd2477
Compare
joviliast
force-pushed
the
emitidx-test
branch
3 times, most recently
from
2f84a39 to
c475830
Compare
ptillet
approved these changes
Mar 11, 2024
Allows to test emmitting indices from different layouts. Valid also for AMD target device. Signed-off-by: joviliast <iveselov.nn@gmail.com>
htyu
pushed a commit
to htyu/triton
that referenced
this pull request
Mar 20, 2024
Allows to test emmitting indices from different layouts. Valid also for AMD target device. Signed-off-by: joviliast <iveselov.nn@gmail.com>
karupayun
pushed a commit
to openxla/triton
that referenced
this pull request
Apr 3, 2024
Allows to test emmitting indices from different layouts. Valid also for AMD target device. Signed-off-by: joviliast <iveselov.nn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to test emmitting indices from different layouts. Valid also for AMD target device.