Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD][Navi31] Add emitIndices logic for WMMA layout #3170

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

joviliast
Copy link
Contributor

-Add emitWmmaOffsetForCTA
-Add emitBaseIndexForWmmaLayout
-Add emitOffsetForWmmaLayout
-Fix some helper methods

@joviliast joviliast requested a review from ptillet as a code owner February 22, 2024 10:31
@joviliast
Copy link
Contributor Author

joviliast commented Feb 22, 2024

PR is tested by EmitIdicesTest here: https://github.com/joviliast/triton/tree/wmma-emit-idx-test
Tests will be added after enabling EmitIdecesTest for AMD. Possible solution is here: #3167 .

@zhanglx13
Copy link
Collaborator

@joviliast Since you have multiple PRs (this one and #3171) that need to be changed for dot3d. I'd suggest we merge them first and work on supporting dot3d later?

-Add emitWmmaOffsetForCTA
-Add emitBaseIndexForWmmaLayout
-Add emitOffsetForWmmaLayout
-Fix some helper methods

Signed-off-by: joviliast <iveselov.nn@gmail.com>
@zhanglx13 zhanglx13 merged commit eb613cd into triton-lang:main Mar 11, 2024
4 checks passed
htyu pushed a commit to htyu/triton that referenced this pull request Mar 20, 2024
-Add emitWmmaOffsetForCTA
-Add emitBaseIndexForWmmaLayout
-Add emitOffsetForWmmaLayout
-Fix some helper methods

Signed-off-by: joviliast <iveselov.nn@gmail.com>
karupayun pushed a commit to openxla/triton that referenced this pull request Apr 3, 2024
-Add emitWmmaOffsetForCTA
-Add emitBaseIndexForWmmaLayout
-Add emitOffsetForWmmaLayout
-Fix some helper methods

Signed-off-by: joviliast <iveselov.nn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants