Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files according to nhs_*.jl #16

Merged
merged 1 commit into from
May 21, 2024

Conversation

LasNikas
Copy link
Collaborator

Keeping in mind that more searches will be added, then this could increase readability in the directory, no?

@LasNikas LasNikas requested a review from efaulhaber May 17, 2024 12:49
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.86%. Comparing base (940941a) to head (e5ae37d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   74.86%   74.86%           
=======================================
  Files           7        7           
  Lines         191      191           
=======================================
  Hits          143      143           
  Misses         48       48           
Flag Coverage Δ
unit 74.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber
Copy link
Member

I have a local branch depending on #8 and #9 where I move these files to a separate folder neighborhood_searches, so that we have neighborhood_searches/trivial.jl, neighborhood_searches/grid.jl and so on.

@efaulhaber efaulhaber merged commit ded6167 into trixi-framework:main May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants