Implement neighborhood search based on static neighbor lists #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 86.16% 88.07% +1.91%
==========================================
Files 10 11 +1
Lines 224 260 +36
==========================================
+ Hits 193 229 +36
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced May 11, 2024
efaulhaber
force-pushed
the
ef/neighbor-lists-nhs
branch
2 times, most recently
from
c131f90
to
3c0c06e
Compare
efaulhaber
force-pushed
the
ef/neighbor-lists-nhs
branch
from
3c0c06e
to
81fe6f1
Compare
efaulhaber
force-pushed
the
ef/neighbor-lists-nhs
branch
from
482143d
to
eecc4a7
Compare
efaulhaber
force-pushed
the
ef/neighbor-lists-nhs
branch
from
eecc4a7
to
7d53ff7
Compare
10 tasks
LasNikas
reviewed
Jun 17, 2024
svchb
requested changes
Jun 17, 2024
LasNikas
approved these changes
Jun 19, 2024
svchb
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally properly implemented the prototype in trixi-framework/TrixiParticles.jl#284.
Based on #13.