-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p4est solver on a spherical mesh #25
Conversation
…tion in Trixi.jl (cherry-picked from f45378e) Co-authored-by: Tristan Montoya <montoya.tristan@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 28.07% 19.32% -8.75%
==========================================
Files 3 8 +5
Lines 570 828 +258
==========================================
Hits 160 160
- Misses 410 668 +258 ☔ View full report in Codecov by Sentry. |
…ltype() and ndims() functions for new struct
I've added my covariant solver to this PR in https://github.com/trixi-framework/TrixiAtmo.jl/tree/tm/p4est_new_container |
@amrueda I think we can merge this even if the dimension check isn't removed from the main Trixi.jl package yet, since my covariant solver will use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this now; tests will be added for the Cartesian solver once the dimension check in Trixi.jl is moved out of the inner constructor for SemidiscretizationHyperbolic.
The new version of Trixi.jl including the fix is released |
Great, thank you! |
This PR implements a version of the 2D p4est solver that runs on a spherical shell that is constructed from a cubed sphere. Since there are three Cartesian space dimensions on the surface of the sphere, we use the 2D p4est solver in combination with a 3D equation.
The connectivities are inherited from the p8est 3D cubed-sphere implementation, but they are adapted to p4est (2D). The discretization strategy follows the approach by:
The following visualization uses this version of Trixi2Vtk:
earth.mp4