Make compatible with Python3 #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2016 10:00
Code had only a few reasons it wasn't compatible with Python3, and all of them were bugs. 1) Inconsistent indentation. Sometimes tabs, sometimes spaces. That's a recipe for trouble and that's why Python3 forbids it. 2) Ambiguity about whether the API values are bytestrings or unicode. Being unsure is a sin, and Python 3 forces clear thinking here. No behavior change for Py2, but Py 3 accepts using only unicode, and we encode at the borders, when fabricating the JSON to send out. 3) print is a function in Python 3, not a statement, so those prints have to look like function calls. That was surprisingly few changes, and only one place had non-one arguments.
|
@JustinDupree you have anyone available to review this ? |
|
I was just about to do this myself. Thanks! |
Remove hard tabs, trailing newlines, trailing spaces
Whitespace cleanups Thanks Adam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code had only a few reasons it wasn't compatible with Python3, and most
of them were bugs.
Inconsistent indentation. Sometimes tabs, sometimes spaces. That's a
recipe for trouble and that's why Python3 forbids it.
Ambiguity about whether the API values are bytestrings or unicode.
Being unsure is a sin, and Python 3 forces clear thinking here. No
behavior change for Py2, but Py 3 accepts using only unicode, and we
encode at the borders, when fabricating the JSON to send out.
print is a function in Python 3, not a statement, so those prints
have to look like function calls. That was surprisingly few changes,
and only one place had non-one arguments.