Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Python3 #39

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Commits on Oct 7, 2016

  1. Make compatible with Python3

    Code had only a few reasons it wasn't compatible with Python3, and all
    of them were bugs.
    
    1) Inconsistent indentation. Sometimes tabs, sometimes spaces. That's a
    recipe for trouble and that's why Python3 forbids it.
    
    2) Ambiguity about whether the API values are bytestrings or unicode.
    Being unsure is a sin, and Python 3 forces clear thinking here. No
    behavior change for Py2, but Py 3 accepts using only unicode, and we
    encode at the borders, when fabricating the JSON to send out.
    
    3) print is a function in Python 3, not a statement, so those prints
    have to look like function calls. That was surprisingly few changes,
    and only one place had non-one arguments.
    Chad Miller committed Oct 7, 2016
    Configuration menu
    Copy the full SHA
    dffa838 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    234c2d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2016

  1. Whitespace cleanups

    Remove hard tabs, trailing newlines, trailing spaces
    AdamNiederer committed Oct 22, 2016
    Configuration menu
    Copy the full SHA
    4bf3d79 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2016

  1. Merge pull request #1 from AdamNiederer/master

    Whitespace cleanups
    
    Thanks Adam.
    chadmiller authored Nov 2, 2016
    Configuration menu
    Copy the full SHA
    8f584e7 View commit details
    Browse the repository at this point in the history