Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dnf upgrade for python bindings build #125

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

dfrankland
Copy link
Member

No description provided.

Copy link

trunk-staging-io bot commented Oct 10, 2024

362 tests were run on 3ba5c57d. ✅ 362 Passed. View Full Report ↗︎

settings

Comment on lines -48 to +49
/usr/bin/dnf upgrade
/usr/bin/dnf install -y pkgconf perl-IPC-Cmd openssl-devel python3-pip
/usr/bin/dnf -y upgrade
/usr/bin/dnf -y install pkgconf perl-IPC-Cmd openssl-devel python3-pip
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I didn't realize dnf upgrade (there's no dnf update) works differently from apt update

@dfrankland dfrankland marked this pull request as ready for review October 10, 2024 23:27
@dfrankland dfrankland requested review from gnalh and max-trunk October 10, 2024 23:27
@dfrankland dfrankland changed the title fix dnf install for python bindings build fix dnf upgrade for python bindings build Oct 10, 2024
@dfrankland dfrankland merged commit d629b81 into main Oct 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants