Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dnf upgrade for python bindings build #125

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix dnf upgrade for python bindings build #125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0b0d2d
fix dnf install for python bindings build
dfrankland Oct 10, 2024
446ac9e
Update pyo3.yml
dfrankland Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pyo3.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ jobs:
# https://docs.rs/openssl/latest/openssl/
if [ -f /usr/bin/dnf ]; then
# quay.io/pypa/manylinux_2_28_x86_64:latest
/usr/bin/dnf upgrade
/usr/bin/dnf install -y pkgconf perl-IPC-Cmd openssl-devel python3-pip
/usr/bin/dnf -y upgrade
/usr/bin/dnf -y install pkgconf perl-IPC-Cmd openssl-devel python3-pip
Comment on lines -48 to +49
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I didn't realize dnf upgrade (there's no dnf update) works differently from apt update

/usr/bin/ln -s /usr/bin/pip3 /usr/bin/pip
/usr/bin/ln -sf /usr/bin/python3.11 /usr/bin/python3
elif [ -f /usr/bin/apt ]; then
Expand Down
Loading