Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] New 404 template example #1619

Closed
suzubara opened this issue Sep 29, 2021 · 3 comments
Closed

[docs] New 404 template example #1619

suzubara opened this issue Sep 29, 2021 · 3 comments
Labels
good first issue Good for newcomers type: documentation Improvements or additions to documentation
Milestone

Comments

@suzubara
Copy link
Contributor

Does this documentation relate to a specific USWDS feature?

USWDS 2.11.0 introduced a 404 page template. We should replicate this in our Storybook.

@suzubara suzubara added the type: documentation Improvements or additions to documentation label Sep 29, 2021
@suzubara suzubara added this to the USWDS 2.11.x milestone Sep 29, 2021
@suzubara suzubara added the good first issue Good for newcomers label Sep 29, 2021
@mvogelgesang
Copy link

@suzubara I'm interested in picking up this issue. While USWDS provides the markup as a page template, making it a component could enhance its ability to support other error codes and messages. Would a pull request that includes both a component and page template be fine?

@svalexander
Copy link

svalexander commented Feb 23, 2022

@suzubara I see there hasn't been a pr for this issue so I gave it a go. Do I need permission to be able to assign the issue to myself and create the pr? I've tried pushing up my branch to main as described in the "Contributing" doc but it's failing due to permissions issues.

@brandonlenz
Copy link
Contributor

Added in #1911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants