Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 404 page template added #2017

Merged
merged 3 commits into from
Apr 22, 2022
Merged

docs: 404 page template added #2017

merged 3 commits into from
Apr 22, 2022

Conversation

hgarfinkle
Copy link
Contributor

@hgarfinkle hgarfinkle commented Apr 21, 2022

This PR originally due to @svalexander. It was recreated by a Truss employee so it could pass the build checks.

Summary

This pr adds a 404 page not found example to the ReactUSWDS Storybook like the one seen in USWDS' documentation. As many of the elements of the template already existed in the documentation template and the authentication templates I borrowed chunks of code from those examples and updated with the appropriate changes.

Related Issues or PRs

#1619

How To Test

  • Run "yarn storybook" to start Storybook locally.
  • Can verify addition of template by navigating to "page templates > not found page".
  • Can then compare template addition with the USWDS 404 example found here.

Screenshots (optional)

Screen Shot 2022-02-25 at 5 18 05 PM

Screen Shot 2022-02-25 at 5 18 15 PM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2022

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against dc103d9

brandonlenz
brandonlenz previously approved these changes Apr 22, 2022
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw a couple of spots using now-removed props. Also some I must've missed in other stories, so I made the update here.

@brandonlenz brandonlenz merged commit 0c9474d into main Apr 22, 2022
@brandonlenz brandonlenz deleted the landing-sa-404template-1619 branch April 22, 2022 15:35
brandonlenz added a commit that referenced this pull request Apr 25, 2022
## [3.0.0](2.9.0...3.0.0) (2022-04-25)


### ⚠ BREAKING CHANGES

* Previous deprecated features and props have been removed. Please see the following guidance for affected components:
  * Accordion: Default heading level has been removed. Consumers must now specify via the `headingLevel` prop.
  * Alert: Default heading level has been removed. Consumers must now specify via the `headingLevel` prop.
  * Button: 
    * `accent` has been removed. Use `accentStyle` instead.
    * `big`, `small`, and `size="small"` have been removed. Use `size="big"` or do not define the `size` prop for default sizing.
  * CollectionHeading: Default heading level has been removed. Consumers must now specify via the `headingLevel` prop.
  * Footer/Address: `big`, `medium`, and `slim` props have been removed. Use the `size` prop instead.
  * Footer/Footer: `big`, `medium`, and `slim` props have been removed. Use the `size` prop instead.
  * Footer/FooterNav: `big`, `medium`, and `small` props have been removed. Use the `size` prop instead.
  * Footer/Logo: `big`, `medium`, and `small` props have been removed. Use the `size` prop instead.
  * Search: `big`, and `small` props have been removed. Use the `size` prop instead.
  * Fieldset: `legendSrOnly` has been removed. Use `legendStyle="srOnly"` instead.
  * TextInput: `error`, and `success` props have been removed. Use the `validationStatus` prop instead.
  * header/NavList: `primary`, `secondary`, `subnav`, `megamenu`, and `footerSecondary` props have been removed. Use the `type` prop instead.
  * StepIndicator: Default heading level has been removed. Consumers must now specify via the `headingLevel` prop.
* SummaryBox now exposes sub-components (SummaryBoxHeading and SummaryBoxContent) for a more compositional API. Consumers will need to update their implementation to match.
* In order to accommodate IconList as a named component, Icons themselves needed to be refactored. All use of ReactUSWDS icons now follows the following syntax: <Icon.{IconName} /> instead of <Icon{IconName />. Furthermore, icons are no longer imported individually. Instead, Icon (the class) is imported to then use any <Icon.{IconName}> consumers require.

### Features

* add isInitiallyOpen option to modal ([#1971](#1971)) ([560564e](560564e))
* Make Summary Box more flexible ([#1929](#1929)) ([a46ed35](a46ed35))
* New Component: IconList ([#1691](#1691)) ([86589ac](86589ac))
* **ci:** add automerge priority label for Kodiak ([#1985](#1985)) ([9dc940e](9dc940e))


* Remove 1.x.x and 2.x.x deprecated properties ([#1988](#1988)) ([5dfadb1](5dfadb1))


### Documentation & Examples

* 404 page template added ([#2017](#2017)) ([0c9474d](0c9474d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants