Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Skip Happo runs on dependabot PRs again #450

Closed
haworku opened this issue Sep 10, 2020 · 5 comments · Fixed by #451, #453 or #474
Closed

[fix] Skip Happo runs on dependabot PRs again #450

haworku opened this issue Sep 10, 2020 · 5 comments · Fixed by #451, #453 or #474
Labels
type: bug Something isn't working like it's supposed to type: dependencies Maintaining 3rd-party dependencies

Comments

@haworku
Copy link
Contributor

haworku commented Sep 10, 2020

Describe the bug
Somewhere in the last month or so Happo stopped skipping for dependabot PRS. This was likely when dependabot switched over to being a Github tool.

Currently, Dependabot is getting is blocked up from automerging regularly by Happo- requiring someone to go in and manually accept the change.

The way we fixed this last time was by adjusting circleci config - specifically adding this condition command '[[ ( "${CIRCLE_PR_USERNAME}" != "dependabot" ) && ( "${CIRCLE_PR_USERNAME}" != "dependabot-preview" ) ]] && yarn happo-ci'. That is no longer working.

To Reproduce

  • See any open dependabot PR that has happo failures. They happen weekly on Mondays.
@haworku haworku added type: bug Something isn't working like it's supposed to type: dependencies Maintaining 3rd-party dependencies labels Sep 10, 2020
@haworku
Copy link
Contributor Author

haworku commented Sep 10, 2020

Reopening because that didn't work. Need to look around more what's going on or try this as GH actions which has a clear way it handles bots.

@haworku haworku reopened this Sep 10, 2020
@haworku
Copy link
Contributor Author

haworku commented Sep 10, 2020

Let's also also consider removing storybook from automated dependency upgrades (this would be a change to dependabot.yml) since that could change the happo output.

@ahobson
Copy link
Contributor

ahobson commented Sep 11, 2020

I notice looking at the CI build step "Preparing environment variables" that CIRCLE_USERNAME is empty for dependabot PRs but it's set for PRs from people. I think that means you can do [[ -n "${CIRCLE_PR_USERNAME}" ]] && yarn happo-ci

@haworku
Copy link
Contributor Author

haworku commented Sep 11, 2020

@ahobson oh thanks!!! I was just reading a github issue where people talking about the PR username being empty in some cases.

@ahobson
Copy link
Contributor

ahobson commented Sep 21, 2020

I gave bad advice. [[ -n "${GITHUB_USERNAME}" ]] && yarn happo-ci exits with a status of 1 if GITHUB_USERNAME is unset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working like it's supposed to type: dependencies Maintaining 3rd-party dependencies
Projects
None yet
2 participants