-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Skip Happo runs on dependabot PRs again #450
Comments
Reopening because that didn't work. Need to look around more what's going on or try this as GH actions which has a clear way it handles bots. |
Let's also also consider removing storybook from automated dependency upgrades (this would be a change to |
I notice looking at the CI build step "Preparing environment variables" that |
@ahobson oh thanks!!! I was just reading a github issue where people talking about the PR username being empty in some cases. |
I gave bad advice. |
Describe the bug
Somewhere in the last month or so Happo stopped skipping for dependabot PRS. This was likely when dependabot switched over to being a Github tool.
Currently, Dependabot is getting is blocked up from automerging regularly by Happo- requiring someone to go in and manually accept the change.
The way we fixed this last time was by adjusting circleci config - specifically adding this condition command
'[[ ( "${CIRCLE_PR_USERNAME}" != "dependabot" ) && ( "${CIRCLE_PR_USERNAME}" != "dependabot-preview" ) ]] && yarn happo-ci'
. That is no longer working.To Reproduce
The text was updated successfully, but these errors were encountered: