Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Happo automation should skip dependabot PRs #453

Merged
merged 8 commits into from
Sep 14, 2020
Merged

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Sep 11, 2020

Summary

Try again- this time only run Happo if the CIRCLE_USERNAME exists (is not empty). Also add storybook to dependencies we ignore for dependabot and manually update.

Related Issues or PRs

closes #450

How To Test

Have to merge to test

@haworku haworku added type: dependencies Maintaining 3rd-party dependencies type: bug Something isn't working like it's supposed to labels Sep 11, 2020
ahobson
ahobson previously approved these changes Sep 11, 2020
Copy link
Contributor

@ahobson ahobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haworku haworku added the status: wip Work in progress - not ready for code review label Sep 11, 2020
@haworku haworku removed the status: wip Work in progress - not ready for code review label Sep 12, 2020
@haworku haworku merged commit dc5bffc into main Sep 14, 2020
@haworku haworku deleted the hw-circleci-happo-450 branch September 14, 2020 20:54
@ahobson ahobson mentioned this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working like it's supposed to type: dependencies Maintaining 3rd-party dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Skip Happo runs on dependabot PRs again
3 participants