-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Happo automation should skip dependabot PRs #453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haworku
requested review from
ahobson,
gidjin,
sarboc,
suzubara and
tinyels
as code owners
September 11, 2020 14:36
haworku
added
type: dependencies
Maintaining 3rd-party dependencies
type: bug
Something isn't working like it's supposed to
labels
Sep 11, 2020
ahobson
previously approved these changes
Sep 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
haworku
force-pushed
the
hw-circleci-happo-450
branch
from
September 11, 2020 20:03
3aab363
to
94cb76b
Compare
suzubara
approved these changes
Sep 14, 2020
ahobson
approved these changes
Sep 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: bug
Something isn't working like it's supposed to
type: dependencies
Maintaining 3rd-party dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try again- this time only run Happo if the
CIRCLE_USERNAME
exists (is not empty). Also add storybook to dependencies we ignore for dependabot and manually update.Related Issues or PRs
closes #450
How To Test
Have to merge to test