Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(peer-deps): support React 18 #2181

Closed
wants to merge 2 commits into from
Closed

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Jul 28, 2022

Fixes #2147.

@lpsinger lpsinger changed the title Support React 18 chore(dep): support React 18 Jul 28, 2022
@lpsinger
Copy link
Contributor Author

Ping!

Copy link

@codydwyertw codydwyertw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like what we need

@lpsinger
Copy link
Contributor Author

Any updates on this?

@gidjin gidjin changed the title chore(dep): support React 18 build(deps-dev): support React 18 Sep 16, 2022
@gidjin gidjin changed the title build(deps-dev): support React 18 build(peer-deps): support React 18 Sep 16, 2022
@gidjin
Copy link
Contributor

gidjin commented Sep 23, 2022

I don't know why this PR isn't registering all the build jobs required. They appear to have run properly and I'm very confused as to why github doesn't see them. My only guess is it's related to the fact that this is coming from a forked repo, but that's all I can see. I opened #2197 which seems to be passing. Closing this in favor of that one.

@gidjin gidjin closed this Sep 23, 2022
@lpsinger lpsinger deleted the react-18 branch September 23, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Dependency issue with current react version
3 participants