-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(peer-deps): add react 18 to peer deps #2197
Conversation
FYI here is the new PR with your change @lpsinger. CC @codydwyertw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved! I did run this change in a react 18 app as well
Thank you for the approval and testing it! |
Thanks for this fix! Ran into the React 18 error in install today and was happy to find this PR already merged after investigating further. Do we know when we'll create a new release with these changes? I was just reading these guidelines on contributing - https://github.com/trussworks/react-uswds/blob/main/docs/releasing.md If folks are amicable to it I could also try putting up a new release? |
I believe only npm maintainers can push the release all the way through the process. That said I plan to go through that process today. |
FYI Release v3.2.0 is out! Thanks for your patience! @aligg @lpsinger @codydwyertw |
Summary
To allow installation of this library in a react 18 app, modifying the peer dep requirement. Thanks @lpsinger and PR #2181
Related Issues or PRs
Fixes #2147
Closes #2181
How To Test
Install in a react 18 app, should install no problem