Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(peer-deps): add react 18 to peer deps #2197

Merged
merged 5 commits into from
Sep 23, 2022

Conversation

gidjin
Copy link
Contributor

@gidjin gidjin commented Sep 23, 2022

Summary

To allow installation of this library in a react 18 app, modifying the peer dep requirement. Thanks @lpsinger and PR #2181

Related Issues or PRs

Fixes #2147
Closes #2181

How To Test

Install in a react 18 app, should install no problem

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

Warnings
⚠️

Changes were made to package.json, but not to yarn.lock - Perhaps you need to run yarn install?

Generated by 🚫 dangerJS against b2de742

@gidjin
Copy link
Contributor Author

gidjin commented Sep 23, 2022

FYI here is the new PR with your change @lpsinger. CC @codydwyertw

haworku
haworku previously approved these changes Sep 23, 2022
Copy link
Contributor

@haworku haworku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! I did run this change in a react 18 app as well

@gidjin
Copy link
Contributor Author

gidjin commented Sep 23, 2022

approved! I did run this change in a react 18 app as well

Thank you for the approval and testing it!

@gidjin gidjin merged commit 5e11093 into main Sep 23, 2022
@gidjin gidjin deleted the gidjin/add_react_18_to_peer_deps branch September 23, 2022 20:21
@aligg
Copy link
Contributor

aligg commented Sep 26, 2022

Thanks for this fix! Ran into the React 18 error in install today and was happy to find this PR already merged after investigating further. Do we know when we'll create a new release with these changes? I was just reading these guidelines on contributing - https://github.com/trussworks/react-uswds/blob/main/docs/releasing.md If folks are amicable to it I could also try putting up a new release?

@gidjin
Copy link
Contributor Author

gidjin commented Sep 27, 2022

Thanks for this fix! Ran into the React 18 error in install today and was happy to find this PR already merged after investigating further. Do we know when we'll create a new release with these changes? I was just reading these guidelines on contributing - https://github.com/trussworks/react-uswds/blob/main/docs/releasing.md If folks are amicable to it I could also try putting up a new release?

I believe only npm maintainers can push the release all the way through the process. That said I plan to go through that process today.

@gidjin
Copy link
Contributor Author

gidjin commented Sep 27, 2022

FYI Release v3.2.0 is out! Thanks for your patience! @aligg @lpsinger @codydwyertw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Dependency issue with current react version
5 participants